fix: more publish fixes

Author: dragonmantank

.github/workflows/publish.yml

@@ -39,11 +39,12 @@ jobs:
           restore-keys: ${{ runner.os }}-gradle
       - name: Publish with Gradle
         env:
-          signingKey: ${{secrets.SIGNING_KEY}}
-          signingPassword: ${{secrets.SIGNING_PASSWORD}}
+          SIGNING_KEY: ${{secrets.SIGNING_KEY}}
+          SIGNING_PASSWORD: ${{secrets.SIGNING_PASSWORD}}
           MAVEN_USERNAME: ${{secrets.MAVEN_USERNAME}}
           MAVEN_SECRET: ${{secrets.MAVEN_SECRET}}
         run: |
-          MAVEN_USERNAME=$MAVEN_USERNAME MAVEN_SECRET=$MAVEN_SECRET
-          signingKey=$signingKey signingPassword=$signingPassword
-          gradle publishMavenJavaPublicationToCentralRepository --info
+          gradle publishMavenJavaPublicationToCentralRepository \
+            -PsigningKey="${SIGNING_KEY}" \
+            -PsigningPassword="${SIGNING_PASSWORD}" \
+            --info

build.gradle

@@ -177,8 +177,11 @@ publishing {
 }
 
 signing {
+    required { gradle.taskGraph.hasTask("publishMavenJavaPublicationToCentralRepository") }
     def signingKey = findProperty("signingKey")
     def signingPassword = findProperty("signingPassword")
-    useInMemoryPgpKeys(signingKey, signingPassword)
-    sign publishing.publications.mavenJava
+    if (signingKey && signingPassword) {
+        useInMemoryPgpKeys(signingKey, signingPassword)
+        sign publishing.publications.mavenJava
+    }
 }