Skip to content

Commit 52026fd

Browse files
authored
Merge pull request #10529 from iyastreb/perftest-final-ack-rndv-assert
PERF: Assertion on final ack message with RNDV
2 parents 3651573 + 7608569 commit 52026fd

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/tools/perf/lib/ucp_tests.cc

+7-5
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ class ucp_perf_test_runner {
3838
m_max_outstanding(m_perf.params.max_outstanding),
3939
m_am_rx_buffer(NULL),
4040
m_am_rx_length(0ul)
41-
4241
{
4342
memset(&m_am_rx_params, 0, sizeof(m_am_rx_params));
4443
memset(&m_send_params, 0, sizeof(m_send_params));
@@ -275,11 +274,12 @@ class ucp_perf_test_runner {
275274
const ucp_am_recv_param_t *rx_params)
276275
{
277276
ucs_assert(!(rx_params->recv_attr & UCP_AM_RECV_ATTR_FLAG_DATA));
278-
ucs_assert(length == ucx_perf_get_message_size(&m_perf.params));
277+
ucs_assertv(length == m_am_rx_length,
278+
"length=%zu expected=%zu index=%u", length, m_am_rx_length,
279+
rte_call(&m_perf, group_index));
279280

280281
ucs_status_ptr_t sp = ucp_am_recv_data_nbx(m_perf.ucp.worker, data,
281-
m_am_rx_buffer,
282-
m_am_rx_length,
282+
m_am_rx_buffer, length,
283283
&m_am_rx_params);
284284
ucs_assert(UCS_PTR_IS_PTR(sp));
285285
ucp_request_release(sp);
@@ -330,7 +330,7 @@ class ucp_perf_test_runner {
330330
ucs_assertv(length == test->m_am_rx_length,
331331
"wrong buffer length %ld != %ld",
332332
length, test->m_am_rx_length);
333-
memcpy(test->m_am_rx_buffer, data, test->m_am_rx_length);
333+
memcpy(test->m_am_rx_buffer, data, length);
334334
}
335335

336336
test->recv_completed();
@@ -909,6 +909,8 @@ class ucp_perf_test_runner {
909909
wait_recv_window(m_max_outstanding);
910910
send_ack(send_buffer, send_datatype);
911911
} else if (my_index == 1) {
912+
/* Sender may only receive final ack */
913+
m_am_rx_length = 1;
912914
UCX_PERF_TEST_FOREACH(&m_perf) {
913915
send(ep, send_buffer, send_length, send_datatype, sn,
914916
remote_addr, rkey, m_perf.current.iters == 0);

0 commit comments

Comments
 (0)