[fix] Setting : instead of - causing issues on uuid

Author: dee077

src/js/netjsongraph.util.js

@@ -1261,7 +1261,7 @@ class NetJSONGraphUtil {
         nodeData = self.data.nodes[index];
       } else if (params.dataType === "edge") {
         const {source, target} = params.data;
-        nodeId = `${source}-${target}`;
+        nodeId = `${source}:${target}`;
         index = self.nodeIndex[source];
         nodeData = self.data.links[index];
       }
@@ -1272,7 +1272,7 @@ class NetJSONGraphUtil {
         nodeData = self.data.nodes[index];
       } else if (params.seriesType === "lines") {
         const {source, target} = params.data.link;
-        nodeId = `${source}-${target}`;
+        nodeId = `${source}:${target}`;
         index = self.nodeIndex[source];
         nodeData = self.data.links[index];
       }
@@ -1306,7 +1306,7 @@ class NetJSONGraphUtil {
     if (!nodeId || !self.nodeIndex || !self.nodeIndex[nodeId] == null) {
       return;
     }
-    const [source, target] = nodeId.split("-");
+    const [source, target] = nodeId.split(":");
     const index = self.nodeIndex[nodeId];
     // If source && target both exists then the node is a link
     const node = source && target ? self.data.links[index] : self.data.nodes[index];

test/netjsongraph.util.test.js

@@ -203,12 +203,12 @@ describe("Test URL fragment utilities", () => {
 
   test("Test parseUrlFragments parses multiple fragments and decodes values", () => {
     window.location.hash =
-      "#id=geoMap&nodeId=abc%3A123;id=indoorMap&nodeId=indoor-node";
+      "#id=geoMap&nodeId=abc%3A123;id=indoorMap&nodeId=indoorNode";
     const fragments = utils.parseUrlFragments();
 
     expect(Object.keys(fragments).sort()).toEqual(["geoMap", "indoorMap"].sort());
     expect(fragments.geoMap.get("nodeId")).toBe("abc:123");
-    expect(fragments.indoorMap.get("nodeId")).toBe("indoor-node");
+    expect(fragments.indoorMap.get("nodeId")).toBe("indoorNode");
   });
 
   test("Test addActionToUrl adds a new fragment with nodeId for a node", () => {
@@ -244,7 +244,7 @@ describe("Test URL fragment utilities", () => {
       },
       data: {links: [link]},
       utils: {...utils, graphRender: "graph", mapRender: "map"},
-      nodeIndex: {"node1-node2": 0},
+      nodeIndex: {"node1:node2": 0},
     };
 
     const params = {
@@ -257,7 +257,7 @@ describe("Test URL fragment utilities", () => {
     const fragments = utils.parseUrlFragments();
     expect(fragments.basicUsage).toBeDefined();
     expect(fragments.basicUsage.get("id")).toBe("basicUsage");
-    expect(fragments.basicUsage.get("nodeId")).toBe("node1-node2");
+    expect(fragments.basicUsage.get("nodeId")).toBe("node1:node2");
   });
 
   test("Test addActionToUrl updates an existing fragment and preserves others", () => {
@@ -345,12 +345,12 @@ describe("Test URL fragment utilities", () => {
         onClickElement: mockOnClick,
       },
       data: {links: [link]},
-      nodeIndex: {"n1-n2": 0},
+      nodeIndex: {"n1:n2": 0},
       leaflet: {setView: mockSetView, getZoom: () => 6},
       utils,
     };
 
-    window.location.hash = "#id=geo&nodeId=n1-n2";
+    window.location.hash = "#id=geo&nodeId=n1:n2";
 
     utils.applyUrlFragmentState(self);