[fix] Qa

Author: dee077

src/js/netjsongraph.util.js

@@ -1244,15 +1244,15 @@ class NetJSONGraphUtil {
     // We store the selected node's data to the browser's history state.
     // This allows the node's information to be retrieved instantly on a back/forward
     // button click without needing to re-parse the entire nodes list.
-    history.pushState(state, "", `#${newHash}`);
+    window.history.pushState(state, "", `#${newHash}`);
   }
 
   addActionToUrl(self, params) {
     if (!self.config.bookmarkableActions.enabled || params.data.cluster) {
       return;
     }
     const fragments = this.parseUrlFragments();
-    const id = self.config.bookmarkableActions.id;
+    const {id} = self.config.bookmarkableActions;
     let nodeId;
     self.indexedNode = self.indexedNode || {};
     if (self.config.render === self.utils.graphRender) {
@@ -1285,8 +1285,10 @@ class NetJSONGraphUtil {
     if (!self.config.bookmarkableActions.enabled || !Object.keys(fragments).length) {
       return;
     }
-    const id = self.config.bookmarkableActions.id;
-    const nodeId = fragments[id]?.get("nodeId");
+    const {id} = self.config.bookmarkableActions;
+    const fragmentParams = fragments[id] && fragments[id].get ? fragments[id] : null;
+    const nodeId =
+      fragmentParams && fragmentParams.get ? fragmentParams.get("nodeId") : undefined;
     if (nodeId === node.id) {
       self.indexedNode = self.indexedNode || {};
       self.indexedNode[nodeId] = node;
@@ -1297,9 +1299,11 @@ class NetJSONGraphUtil {
     if (!self.config.bookmarkableActions.enabled) {
       return;
     }
-    const id = self.config.bookmarkableActions.id;
+    const {id} = self.config.bookmarkableActions;
     const fragments = self.utils.parseUrlFragments();
-    const nodeId = fragments[id]?.get("nodeId");
+    const fragmentParams = fragments[id] && fragments[id].get ? fragments[id] : null;
+    const nodeId =
+      fragmentParams && fragmentParams.get ? fragmentParams.get("nodeId") : undefined;
     if (!self.indexedNode || !self.indexedNode[nodeId]) {
       return;
     }

test/netjsongraph.util.test.js

@@ -216,7 +216,7 @@ describe("Test URL fragment utilities", () => {
       config: {
         bookmarkableActions: {enabled: true, id: "geoMap"},
       },
-      utils: utils,
+      utils,
     };
     const params = {
       componentSubType: "effectScatter",
@@ -239,10 +239,10 @@ describe("Test URL fragment utilities", () => {
         bookmarkableActions: {enabled: true, id: "geo"},
       },
       indexedNode: undefined,
-      utils: utils,
+      utils,
     };
     const params = {
-      data:{node: {id: "node-2"}},
+      data: {node: {id: "node-2"}},
     };
 
     utils.addActionToUrl(self, params);
@@ -314,13 +314,19 @@ describe("Test URL fragment utilities", () => {
       },
       emit(event) {
         const h = this.handlers[event];
-        if (h) h();
+        if (h) {
+          h();
+        }
       },
     };
+    const delay = (ms) =>
+      new Promise((resolve) => {
+        setTimeout(resolve, ms);
+      });
 
     const asyncOnReady = async () => {
       recorder.push("onReady-start");
-      await new Promise((r) => setTimeout(r, 20));
+      await delay(20);
       recorder.push("onReady-done");
     };
 
@@ -337,7 +343,7 @@ describe("Test URL fragment utilities", () => {
     });
     emitter.emit("onReady");
     emitter.emit("applyUrlFragmentState");
-    await new Promise((r) => setTimeout(r, 40));
+    await delay(40);
     expect(recorder).toEqual([
       "onReady-start",
       "onReady-done",