Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Source Tarball in Release #861

Open
michaelquigley opened this issue Feb 10, 2025 · 2 comments
Open

Upload Source Tarball in Release #861

michaelquigley opened this issue Feb 10, 2025 · 2 comments
Assignees
Labels
enhancement Enhancement of an existing feature spike Requires R&D; figure it out
Milestone

Comments

@michaelquigley
Copy link
Collaborator

Upload a source tarball as part of the release process, rather than relying on GitHub's automatically generated tarballs. The generated tarballs can cause issues if git attributes change (or other potentially undiscovered shifts), which can break Homebrew releases (with checksum mismatches).

Also update the Homebrew release process to use the uploaded tarball instead of the generated GitHub tarball.

@michaelquigley michaelquigley self-assigned this Feb 10, 2025
@michaelquigley michaelquigley added enhancement Enhancement of an existing feature spike Requires R&D; figure it out labels Feb 10, 2025
@michaelquigley michaelquigley added this to the v1.0 milestone Feb 10, 2025
@qrkourier
Copy link
Member

Michael, I'd like to steal this issue and include it in a batch of release artifact changes I'm planning for zrok and ziti to adopt industry-standard attestations for the release binaries and container images.

@michaelquigley
Copy link
Collaborator Author

What is your ETA on it? I'd like this to be completed in the next ~week, so that it is implemented before the first production drop of 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature spike Requires R&D; figure it out
Projects
Development

No branches or pull requests

2 participants