Skip to content

Commit fca322e

Browse files
committed
Support customization in test-e2e-ansible-molecule
Signed-off-by: arkadeepsen <[email protected]>
1 parent ea8d50a commit fca322e

File tree

2 files changed

+35
-15
lines changed

2 files changed

+35
-15
lines changed

Makefile

+7-1
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,14 @@ test-e2e-ansible:: image/ansible-operator test-e2e-ansible-run ## Run Ansible e2
166166
test-e2e-ansible-run:
167167
go test ./test/e2e/ansible -v -ginkgo.v
168168

169-
test-e2e-ansible-molecule:: install dev-install image/ansible-operator ## Run molecule-based Ansible e2e tests
169+
test-e2e-ansible-molecule:: install dev-install image/ansible-operator test-e2e-ansible-molecule-generate test-e2e-ansible-molecule-run ## Run molecule-based Ansible e2e tests
170+
171+
.PHONY: test-e2e-ansible-molecule-generate
172+
test-e2e-ansible-molecule-generate:
170173
go run ./hack/generate/samples/molecule/generate.go
174+
175+
.PHONY: test-e2e-ansible-molecule-run
176+
test-e2e-ansible-molecule-run:
171177
./hack/tests/e2e-ansible-molecule.sh
172178

173179
## Location to install dependencies to

hack/tests/e2e-ansible-molecule.sh

+28-14
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,27 @@ ROOTDIR="$(pwd)"
4040
cp -r $ROOTDIR/testdata/ansible/memcached-molecule-operator/ $TMPDIR/memcached-molecule-operator
4141
cp -r $ROOTDIR/testdata/ansible/advanced-molecule-operator/ $TMPDIR/advanced-molecule-operator
4242

43-
pushd $TMPDIR/memcached-molecule-operator
43+
# Skip Kind test with memcached-molecule-operator if ADVANCED_MOLECULE_OPERATOR_IMAGE has a value.
44+
if [ -z "${ADVANCED_MOLECULE_OPERATOR_IMAGE-}" ] ; then
45+
pushd $TMPDIR/memcached-molecule-operator
4446

45-
header_text "Running Kind test with memcached-molecule-operator"
46-
make kustomize
47-
if [ -f ./bin/kustomize ] ; then
48-
KUSTOMIZE="$(realpath ./bin/kustomize)"
49-
else
50-
KUSTOMIZE="$(which kustomize)"
47+
header_text "Running Kind test with memcached-molecule-operator"
48+
make kustomize
49+
if [ -f ./bin/kustomize ] ; then
50+
KUSTOMIZE="$(realpath ./bin/kustomize)"
51+
else
52+
KUSTOMIZE="$(which kustomize)"
53+
fi
54+
KUSTOMIZE_PATH=${KUSTOMIZE} TEST_OPERATOR_NAMESPACE=default molecule test -s kind
55+
popd
5156
fi
52-
KUSTOMIZE_PATH=${KUSTOMIZE} TEST_OPERATOR_NAMESPACE=default molecule test -s kind
53-
popd
5457

5558
header_text "Running Default test with advanced-molecule-operator"
5659

57-
make test-e2e-setup
60+
# Skip creation of Kind cluster if ADVANCED_MOLECULE_OPERATOR_IMAGE has a value.
61+
if [ -z "${ADVANCED_MOLECULE_OPERATOR_IMAGE-}" ] ; then
62+
make test-e2e-setup
63+
fi
5864
pushd $TMPDIR/advanced-molecule-operator
5965

6066
make kustomize
@@ -64,8 +70,16 @@ else
6470
KUSTOMIZE="$(which kustomize)"
6571
fi
6672

67-
DEST_IMAGE="quay.io/example/advanced-molecule-operator:v0.0.1"
68-
docker build -t "$DEST_IMAGE" --no-cache .
69-
load_image_if_kind "$DEST_IMAGE"
70-
KUSTOMIZE_PATH=$KUSTOMIZE OPERATOR_PULL_POLICY=Never OPERATOR_IMAGE=${DEST_IMAGE} TEST_OPERATOR_NAMESPACE=osdk-test molecule test
73+
# Check if ADVANCED_MOLECULE_OPERATOR_IMAGE has value or not. If it doesn't have a value then proceed with the test
74+
# using a Kind cluster, otherwise proceed with the test without the Kind cluster.
75+
if [ -z "${ADVANCED_MOLECULE_OPERATOR_IMAGE-}" ] ; then
76+
DEST_IMAGE="quay.io/example/advanced-molecule-operator:v0.0.1"
77+
docker build -t "$DEST_IMAGE" --no-cache .
78+
load_image_if_kind "$DEST_IMAGE"
79+
IMAGE_PULL_POLICY="Never"
80+
else
81+
DEST_IMAGE=${ADVANCED_MOLECULE_OPERATOR_IMAGE}
82+
IMAGE_PULL_POLICY="IfNotPresent"
83+
fi
84+
KUSTOMIZE_PATH=$KUSTOMIZE OPERATOR_PULL_POLICY=${IMAGE_PULL_POLICY} OPERATOR_IMAGE=${DEST_IMAGE} TEST_OPERATOR_NAMESPACE=osdk-test molecule test
7185
popd

0 commit comments

Comments
 (0)