Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php #8180

Closed
abonanni opened this issue Jan 4, 2025 · 2 comments
Closed

Regression in src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php #8180

abonanni opened this issue Jan 4, 2025 · 2 comments
Assignees
@AdSchellevis
Labels
bug Production bug
Milestone
25.1

Comments

@abonanni
Copy link

abonanni commented Jan 4, 2025

In file /usr/local/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php line 126 :
if (!empty($this->internalConfigdPopulateAct)) { code populate list only if variable internalConfigdPopulateAct is not empty.

This update make a bug in categories widget of blacklist in the os-squid module.

Linked to following issues :

@AdSchellevis could you look at this request ? Thanks
@AdSchellevis AdSchellevis self-assigned this Jan 4, 2025
@AdSchellevis AdSchellevis added the bug Production bug label Jan 4, 2025
@AdSchellevis
Copy link
Member

AdSchellevis commented Jan 5, 2025 •
edited
Loading

@abonanni can you try e150a57 ?

AdSchellevis added a commit that referenced this issue Jan 6, 2025
@AdSchellevis
mvc:JsonKeyValueStoreField - restore support for json input data with…
e150a57 
…out configd callout, closes #8180

partially reverts 525481c
fichtner pushed a commit that referenced this issue Jan 8, 2025
@AdSchellevis @fichtner
mvc:JsonKeyValueStoreField - restore support for json input data with…
b9ae3f9 
…out configd callout, closes #8180

partially reverts 525481c

(cherry picked from commit e150a57)
@abonanni
Copy link
Author

@AdSchellevis it seems to be OK. Thanks

@fichtner fichtner added this to the 25.1 milestone Jan 11, 2025
@AdSchellevis AdSchellevis mentioned this issue Jan 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
bug Production bug
Milestone
25.1
Development

No branches or pull requests
3 participants
@fichtner @AdSchellevis @abonanni