Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipsec: mobile page needs migration to MVC/API and/or split of legacy feature set #8349

Closed
2 tasks done
fichtner opened this issue Feb 19, 2025 · 2 comments · Fixed by #8380
Closed
2 tasks done

ipsec: mobile page needs migration to MVC/API and/or split of legacy feature set #8349

fichtner opened this issue Feb 19, 2025 · 2 comments · Fixed by #8380
Assignees
@AdSchellevis
Labels
feature Adding new functionality roadmap Major roadmap item
Milestone
25.7

Comments

@fichtner
Copy link
Member

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.

Since the legacy components move to a plugin the mobile page needs some attention of what most stay in core and what doesn't.

Describe the solution you like

Migrate or split vpn_ipsec_mobile.php.

Describe alternatives you considered

Removing the code or keeping as is. Not a great plan.

Additional context

#8348
@fichtner fichtner added feature Adding new functionality roadmap Major roadmap item labels Feb 19, 2025
@fichtner fichtner added this to the 25.7 milestone Feb 19, 2025
@Monviech
Copy link
Member

As reference, this is how mobile users are set up in Connections without the mobile users page necessary:
https://docs.opnsense.org/manual/how-tos/ipsec-swanctl-rw-ikev2-eap-mschapv2.html

@AdSchellevis
Copy link
Member

The reason for migration is mostly for the extensions, which are used for both.

AdSchellevis added a commit that referenced this issue Feb 26, 2025
@AdSchellevis
VPN: IPsec: Mobile Clients - move charon attributes to "Advanced sett…
94f61e8 
…ings" for #8349
AdSchellevis added a commit that referenced this issue Feb 27, 2025
@AdSchellevis
VPN: IPsec: Mobile Clients - move charon attributes to "Advanced sett…
9a16ca7 
…ings" for #8349
AdSchellevis added a commit that referenced this issue Feb 27, 2025
@AdSchellevis
VPN: IPsec: Mobile Clients - move charon attributes to "Advanced sett…
8c04662 
…ings" for #8349

Rename previous "advanced settings" to "mobile & advanced settings" to guide people into the right direction, strongswan.conf contains both sets of data.
Keep legacy page for settings that are only relevant for the old components.

Since our pam authenticator hooks into the configuration, refactor to use the model as well.

Cleanup code in the model that was only used in the legacy glue.
@AdSchellevis AdSchellevis mentioned this issue Feb 27, 2025
Merged
AdSchellevis added a commit that referenced this issue Feb 28, 2025
@AdSchellevis
VPN: IPsec: Mobile Clients - move charon attributes to "Advanced sett…
a893cdc 
…ings" for #8349 (#8380)

Rename previous "advanced settings" to "mobile & advanced settings" to guide people into the right direction, strongswan.conf contains both sets of data.
Keep legacy page for settings that are only relevant for the old components.

Since our pam authenticator hooks into the configuration, refactor to use the model as well.

Cleanup code in the model that was only used in the legacy glue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
feature Adding new functionality roadmap Major roadmap item
Milestone
25.7
Development

Successfully merging a pull request may close this issue.

VPN: IPsec: Mobile Clients - move charon attributes to opnsense/core
3 participants
@fichtner @AdSchellevis @Monviech