OpenVPN client Override has no option for topology

[tsdogs]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• [ X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• [ X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

If an OpenVPN instance is configured with Topology subnet and a Client Override is used with Push reset option, the topology does not get pushed to the client (as per OpenVPN documentation) some clients (like on Mac OS) will complain that the pushed IP is wrong (as default is net30)

To Reproduce

Steps to reproduce the behavior:

1. Configure a OpenVPN Instance with topology subnet
2. Configure a client specific override with advances push reset option (so not to push all the options specifically the subnets) and set the specific pushed IP
3. Connect using OpenVPN which should complain about the wrong ifconfig push option

Expected behavior

There should also be an option in the Client Specific Override to set topology subnet (or a general additional settings option to put specific other settings)

Describe alternatives you considered

If you use "topology subnet" in the client export on Windows it seems to be working

[tsdogs]

[AdSchellevis]

I don't expect this is an option you can push via client specific overwrites, best check the upstream documentation https://openvpn.net/community-resources/reference-manual-for-openvpn-2-6/

[tsdogs]

I probably mis-understood the documentation.
Would it be a good alternative to have a push-delete option then?

In the "bug" report seems that pushing it again (as a work around) should work, but haven't tested it.
https://community.openvpn.net/openvpn/ticket/29

[AdSchellevis]

I'm not sure, it probably depends on the client, but I would expect these options in the client config to be honest. you can always experiment yourself, the client specific overwrites are flushed to disk in this function :

core/src/etc/inc/plugins.inc.d/openvpn.inc

Line 981 in 3caf9e1

function openvpn_csc_conf_write($settings, $server, $target_filename = null)