Update php.ini to add dynamic session.name value #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure we should change the session names for all users (and leak hostnames in the process) for a single use-case. We'll leave this one open for now for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
session.name={{system.hostname}}to the last line ofsrc/opnsense/service/templates/OPNsense/WebGui/php.iniso that OPNSense sessions do not use the PHP defaultPHPSESSIDcookie name. This PR permits multiple OPNSense instances to operate on the same hostname (e.g. via localhost from SSH tunneled sessions) without interfering with each other.Fixes #8365