fix: refactor getUrl method to use URL appendingPathComponent

muzahidul-opti · muzahidul-opti · commit 4fe4bc2a1205 · 2025-11-27T23:08:12.000+06:00
diff --git a/Sources/CMAB/CmabClient.swift b/Sources/CMAB/CmabClient.swift
@@ -101,12 +101,11 @@ class DefaultCmabClient: CmabClient {
     }
     
     func getUrl(ruleId: String) -> URL? {
-        let urlString = predictionEndpoint.hasSuffix("/") ? "predictionEndpoint\(ruleId)" : "\(predictionEndpoint)/\(ruleId)"
-        guard let url = URL(string: urlString) else {
+        guard let baseURL = URL(string: predictionEndpoint) else {
             self.logger.e("Invalid CMAB endpoint")
             return nil
         }
-        return url
+        return baseURL.appendingPathComponent(ruleId)
     }
     
     private func doFetchWithRetry(

Original file line number	Diff line number	Diff line change
`@@ -101,12 +101,11 @@ class DefaultCmabClient: CmabClient {`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`func getUrl(ruleId: String) -> URL? {`
`104`		`- let urlString = predictionEndpoint.hasSuffix("/") ? "predictionEndpoint\(ruleId)" : "\(predictionEndpoint)/\(ruleId)"`
`105`		`- guard let url = URL(string: urlString) else {`
	`104`	`+ guard let baseURL = URL(string: predictionEndpoint) else {`
`106`	`105`	`self.logger.e("Invalid CMAB endpoint")`
`107`	`106`	`return nil`
`108`	`107`	`}`
`109`		`- return url`
	`108`	`+ return baseURL.appendingPathComponent(ruleId)`
`110`	`109`	`}`
`111`	`110`
`112`	`111`	`private func doFetchWithRetry(`