Skip to content

Commit 05a409b

Browse files
Merge branch 'main' into fix/metadata-api-changes
2 parents cf22cb2 + 04808f7 commit 05a409b

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed

ads/aqua/evaluation/evaluation.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,10 @@ def create(
260260
**create_aqua_evaluation_details.model_parameters,
261261
)
262262

263+
evaluation_model_defined_tags = (
264+
create_aqua_evaluation_details.defined_tags or {}
265+
)
266+
263267
target_compartment = (
264268
create_aqua_evaluation_details.compartment_id or COMPARTMENT_OCID
265269
)
@@ -311,9 +315,7 @@ def create(
311315
create_aqua_evaluation_details.experiment_description
312316
)
313317
.with_freeform_tags(**evaluation_mvs_freeform_tags)
314-
.with_defined_tags(
315-
**(create_aqua_evaluation_details.defined_tags or {})
316-
)
318+
.with_defined_tags(**evaluation_model_defined_tags)
317319
# TODO: decide what parameters will be needed
318320
.create(**kwargs)
319321
)
@@ -358,6 +360,7 @@ def create(
358360
.with_custom_metadata_list(evaluation_model_custom_metadata)
359361
.with_defined_metadata_list(evaluation_model_taxonomy_metadata)
360362
.with_provenance_metadata(ModelProvenanceMetadata(training_id=UNKNOWN))
363+
.with_defined_tags(**evaluation_model_defined_tags)
361364
# TODO uncomment this once the evaluation container will get the updated version of the ADS
362365
# .with_input_schema(create_aqua_evaluation_details.to_dict())
363366
# TODO: decide what parameters will be needed
@@ -390,7 +393,7 @@ def create(
390393
.with_shape_name(create_aqua_evaluation_details.shape_name)
391394
.with_block_storage_size(create_aqua_evaluation_details.block_storage_size)
392395
.with_freeform_tag(**evaluation_job_freeform_tags)
393-
.with_defined_tag(**(create_aqua_evaluation_details.defined_tags or {}))
396+
.with_defined_tag(**evaluation_model_defined_tags)
394397
)
395398
if (
396399
create_aqua_evaluation_details.memory_in_gbs
@@ -429,15 +432,17 @@ def create(
429432
metrics=create_aqua_evaluation_details.metrics,
430433
inference_configuration=eval_inference_configuration or {},
431434
)
432-
).create(**kwargs) ## TODO: decide what parameters will be needed
435+
).create(
436+
**kwargs
437+
) ## TODO: decide what parameters will be needed
433438
logger.debug(
434439
f"Successfully created evaluation job {evaluation_job.id} for {create_aqua_evaluation_details.evaluation_source_id}."
435440
)
436441

437442
evaluation_job_run = evaluation_job.run(
438443
name=evaluation_model.display_name,
439444
freeform_tags=evaluation_job_freeform_tags,
440-
defined_tags=(create_aqua_evaluation_details.defined_tags or {}),
445+
defined_tags=evaluation_model_defined_tags,
441446
wait=False,
442447
)
443448
logger.debug(
@@ -461,16 +466,12 @@ def create(
461466
Tags.AQUA_EVALUATION: Tags.AQUA_EVALUATION,
462467
**(create_aqua_evaluation_details.freeform_tags or {}),
463468
}
464-
evaluation_model_defined_tags = (
465-
create_aqua_evaluation_details.defined_tags or {}
466-
)
467469

468470
self.ds_client.update_model(
469471
model_id=evaluation_model.id,
470472
update_model_details=UpdateModelDetails(
471473
custom_metadata_list=updated_custom_metadata_list,
472474
freeform_tags=evaluation_model_freeform_tags,
473-
defined_tags=evaluation_model_defined_tags,
474475
),
475476
)
476477

docs/source/release_notes.rst

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,23 @@
22
Release Notes
33
=============
44

5+
2.13.3
6+
-------
7+
Release date: March 21, 2025
8+
9+
* Fixed defined tag permission issue when creating AI Quick Action fine-tuning and evaluation.
10+
11+
512
2.13.2
613
-------
7-
Release date: March 14th, 2025
14+
Release date: March 14, 2025
815

916
* Fixed bug in DataScienceModel defined metadata.
1017

1118

1219
2.13.1
1320
-------
14-
Release date: March 13th, 2025
21+
Release date: March 13, 2025
1522

1623

1724
* Upgraded OCI SDK to ``v2.148.0`` for improved compatibility and performance.
@@ -35,21 +42,21 @@ Release date: March 13th, 2025
3542

3643
2.13.0
3744
-------
38-
Release date: Feb 14th, 2025
45+
Release date: Feb 14, 2025
3946

4047
* Fixed bug in DataScienceModel defined metadata where non-predefined metadata keys caused errors.
4148

4249

4350
2.12.11
4451
-------
45-
Release date: Feb 5th, 2025
52+
Release date: Feb 5, 2025
4653

4754
* Fixed bug while loading model configuration in AI Quick Actions.
4855

4956

5057
2.12.10
5158
-------
52-
Release date: Feb 5th, 2025
59+
Release date: Feb 5, 2025
5360

5461
* Support inference container URI to be edited for unverified models in AI Quick Actions.
5562
* Logging improvements for all CRUD operations in AI Quick Actions.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ build-backend = "flit_core.buildapi"
2121

2222
# Required
2323
name = "oracle_ads" # the install (PyPI) name; name for local build in [tool.flit.module] section below
24-
version = "2.13.2"
24+
version = "2.13.3"
2525

2626
# Optional
2727
description = "Oracle Accelerated Data Science SDK"

0 commit comments

Comments
 (0)