Skip to content

Commit 1c1702b

Browse files
authored
Merge branch 'main' into feature/multi_model_deployment
2 parents 6408add + 04808f7 commit 1c1702b

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed

ads/aqua/evaluation/evaluation.py

+11-10
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,10 @@ def create(
329329
**create_aqua_evaluation_details.model_parameters,
330330
)
331331

332+
evaluation_model_defined_tags = (
333+
create_aqua_evaluation_details.defined_tags or {}
334+
)
335+
332336
target_compartment = (
333337
create_aqua_evaluation_details.compartment_id or COMPARTMENT_OCID
334338
)
@@ -380,9 +384,7 @@ def create(
380384
create_aqua_evaluation_details.experiment_description
381385
)
382386
.with_freeform_tags(**evaluation_mvs_freeform_tags)
383-
.with_defined_tags(
384-
**(create_aqua_evaluation_details.defined_tags or {})
385-
)
387+
.with_defined_tags(**evaluation_model_defined_tags)
386388
# TODO: decide what parameters will be needed
387389
.create(**kwargs)
388390
)
@@ -427,6 +429,7 @@ def create(
427429
.with_custom_metadata_list(evaluation_model_custom_metadata)
428430
.with_defined_metadata_list(evaluation_model_taxonomy_metadata)
429431
.with_provenance_metadata(ModelProvenanceMetadata(training_id=UNKNOWN))
432+
.with_defined_tags(**evaluation_model_defined_tags)
430433
# TODO uncomment this once the evaluation container will get the updated version of the ADS
431434
# .with_input_schema(create_aqua_evaluation_details.to_dict())
432435
# TODO: decide what parameters will be needed
@@ -459,7 +462,7 @@ def create(
459462
.with_shape_name(create_aqua_evaluation_details.shape_name)
460463
.with_block_storage_size(create_aqua_evaluation_details.block_storage_size)
461464
.with_freeform_tag(**evaluation_job_freeform_tags)
462-
.with_defined_tag(**(create_aqua_evaluation_details.defined_tags or {}))
465+
.with_defined_tag(**evaluation_model_defined_tags)
463466
)
464467
if (
465468
create_aqua_evaluation_details.memory_in_gbs
@@ -501,15 +504,17 @@ def create(
501504
metrics=create_aqua_evaluation_details.metrics,
502505
inference_configuration=eval_inference_configuration or {},
503506
)
504-
).create(**kwargs) ## TODO: decide what parameters will be needed
507+
).create(
508+
**kwargs
509+
) ## TODO: decide what parameters will be needed
505510
logger.debug(
506511
f"Successfully created evaluation job {evaluation_job.id} for {create_aqua_evaluation_details.evaluation_source_id}."
507512
)
508513

509514
evaluation_job_run = evaluation_job.run(
510515
name=evaluation_model.display_name,
511516
freeform_tags=evaluation_job_freeform_tags,
512-
defined_tags=(create_aqua_evaluation_details.defined_tags or {}),
517+
defined_tags=evaluation_model_defined_tags,
513518
wait=False,
514519
)
515520
logger.debug(
@@ -533,16 +538,12 @@ def create(
533538
Tags.AQUA_EVALUATION: Tags.AQUA_EVALUATION,
534539
**(create_aqua_evaluation_details.freeform_tags or {}),
535540
}
536-
evaluation_model_defined_tags = (
537-
create_aqua_evaluation_details.defined_tags or {}
538-
)
539541

540542
self.ds_client.update_model(
541543
model_id=evaluation_model.id,
542544
update_model_details=UpdateModelDetails(
543545
custom_metadata_list=updated_custom_metadata_list,
544546
freeform_tags=evaluation_model_freeform_tags,
545-
defined_tags=evaluation_model_defined_tags,
546547
),
547548
)
548549

docs/source/release_notes.rst

+12-5
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,23 @@
22
Release Notes
33
=============
44

5+
2.13.3
6+
-------
7+
Release date: March 21, 2025
8+
9+
* Fixed defined tag permission issue when creating AI Quick Action fine-tuning and evaluation.
10+
11+
512
2.13.2
613
-------
7-
Release date: March 14th, 2025
14+
Release date: March 14, 2025
815

916
* Fixed bug in DataScienceModel defined metadata.
1017

1118

1219
2.13.1
1320
-------
14-
Release date: March 13th, 2025
21+
Release date: March 13, 2025
1522

1623

1724
* Upgraded OCI SDK to ``v2.148.0`` for improved compatibility and performance.
@@ -35,21 +42,21 @@ Release date: March 13th, 2025
3542

3643
2.13.0
3744
-------
38-
Release date: Feb 14th, 2025
45+
Release date: Feb 14, 2025
3946

4047
* Fixed bug in DataScienceModel defined metadata where non-predefined metadata keys caused errors.
4148

4249

4350
2.12.11
4451
-------
45-
Release date: Feb 5th, 2025
52+
Release date: Feb 5, 2025
4653

4754
* Fixed bug while loading model configuration in AI Quick Actions.
4855

4956

5057
2.12.10
5158
-------
52-
Release date: Feb 5th, 2025
59+
Release date: Feb 5, 2025
5360

5461
* Support inference container URI to be edited for unverified models in AI Quick Actions.
5562
* Logging improvements for all CRUD operations in AI Quick Actions.

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ build-backend = "flit_core.buildapi"
2121

2222
# Required
2323
name = "oracle_ads" # the install (PyPI) name; name for local build in [tool.flit.module] section below
24-
version = "2.13.2"
24+
version = "2.13.3"
2525

2626
# Optional
2727
description = "Oracle Accelerated Data Science SDK"

0 commit comments

Comments
 (0)