Skip to content

Commit 27edc84

Browse files
authored
defined tag support while creating model (#1122)
2 parents 35cccdd + c810e3a commit 27edc84

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ads/aqua/app.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ def create_model_catalog(
225225
model_taxonomy_metadata: Union[ModelTaxonomyMetadata, Dict],
226226
compartment_id: str,
227227
project_id: str,
228+
defined_tags: Dict = None,
228229
**kwargs,
229230
) -> DataScienceModel:
230231
model = (
@@ -237,7 +238,7 @@ def create_model_catalog(
237238
.with_custom_metadata_list(model_custom_metadata)
238239
.with_defined_metadata_list(model_taxonomy_metadata)
239240
.with_provenance_metadata(ModelProvenanceMetadata(training_id=UNKNOWN))
240-
# TODO: decide what parameters will be needed
241+
.with_defined_tags(**(defined_tags or {})) # Create defined tags when a model is created.
241242
.create(
242243
**kwargs,
243244
)

ads/aqua/finetuning/finetuning.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ def create(
263263
compartment_id=target_compartment,
264264
project_id=target_project,
265265
model_by_reference=True,
266+
defined_tags=create_fine_tuning_details.defined_tags
266267
)
267268

268269
ft_job_freeform_tags = {
@@ -382,14 +383,12 @@ def create(
382383
Tags.AQUA_FINE_TUNED_MODEL_TAG: f"{source.id}#{source.display_name}",
383384
**(create_fine_tuning_details.freeform_tags or {}),
384385
}
385-
model_defined_tags = create_fine_tuning_details.defined_tags or {}
386386

387387
self.update_model(
388388
model_id=ft_model.id,
389389
update_model_details=UpdateModelDetails(
390390
custom_metadata_list=updated_custom_metadata_list,
391391
freeform_tags=model_freeform_tags,
392-
defined_tags=model_defined_tags,
393392
),
394393
)
395394
logger.debug(
@@ -490,7 +489,7 @@ def create(
490489
"finetuning_source": source.id,
491490
"finetuning_experiment_id": experiment_model_version_set_id,
492491
**model_freeform_tags,
493-
**model_defined_tags,
492+
**(create_fine_tuning_details.defined_tags or {}),
494493
},
495494
parameters=ft_parameters,
496495
)

0 commit comments

Comments
 (0)