Skip to content

Commit 8e94b6d

Browse files
Merge branch 'main' into aqua/ADS_MS_changes
2 parents eb5fb40 + 04808f7 commit 8e94b6d

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed

ads/aqua/evaluation/evaluation.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,10 @@ def create(
261261
**create_aqua_evaluation_details.model_parameters,
262262
)
263263

264+
evaluation_model_defined_tags = (
265+
create_aqua_evaluation_details.defined_tags or {}
266+
)
267+
264268
target_compartment = (
265269
create_aqua_evaluation_details.compartment_id or COMPARTMENT_OCID
266270
)
@@ -312,9 +316,7 @@ def create(
312316
create_aqua_evaluation_details.experiment_description
313317
)
314318
.with_freeform_tags(**evaluation_mvs_freeform_tags)
315-
.with_defined_tags(
316-
**(create_aqua_evaluation_details.defined_tags or {})
317-
)
319+
.with_defined_tags(**evaluation_model_defined_tags)
318320
# TODO: decide what parameters will be needed
319321
.create(**kwargs)
320322
)
@@ -359,6 +361,7 @@ def create(
359361
.with_custom_metadata_list(evaluation_model_custom_metadata)
360362
.with_defined_metadata_list(evaluation_model_taxonomy_metadata)
361363
.with_provenance_metadata(ModelProvenanceMetadata(training_id=UNKNOWN))
364+
.with_defined_tags(**evaluation_model_defined_tags)
362365
# TODO uncomment this once the evaluation container will get the updated version of the ADS
363366
# .with_input_schema(create_aqua_evaluation_details.to_dict())
364367
# TODO: decide what parameters will be needed
@@ -391,7 +394,7 @@ def create(
391394
.with_shape_name(create_aqua_evaluation_details.shape_name)
392395
.with_block_storage_size(create_aqua_evaluation_details.block_storage_size)
393396
.with_freeform_tag(**evaluation_job_freeform_tags)
394-
.with_defined_tag(**(create_aqua_evaluation_details.defined_tags or {}))
397+
.with_defined_tag(**evaluation_model_defined_tags)
395398
)
396399
if (
397400
create_aqua_evaluation_details.memory_in_gbs
@@ -430,15 +433,17 @@ def create(
430433
metrics=create_aqua_evaluation_details.metrics,
431434
inference_configuration=eval_inference_configuration or {},
432435
)
433-
).create(**kwargs) ## TODO: decide what parameters will be needed
436+
).create(
437+
**kwargs
438+
) ## TODO: decide what parameters will be needed
434439
logger.debug(
435440
f"Successfully created evaluation job {evaluation_job.id} for {create_aqua_evaluation_details.evaluation_source_id}."
436441
)
437442

438443
evaluation_job_run = evaluation_job.run(
439444
name=evaluation_model.display_name,
440445
freeform_tags=evaluation_job_freeform_tags,
441-
defined_tags=(create_aqua_evaluation_details.defined_tags or {}),
446+
defined_tags=evaluation_model_defined_tags,
442447
wait=False,
443448
)
444449
logger.debug(
@@ -462,16 +467,12 @@ def create(
462467
Tags.AQUA_EVALUATION: Tags.AQUA_EVALUATION,
463468
**(create_aqua_evaluation_details.freeform_tags or {}),
464469
}
465-
evaluation_model_defined_tags = (
466-
create_aqua_evaluation_details.defined_tags or {}
467-
)
468470

469471
self.ds_client.update_model(
470472
model_id=evaluation_model.id,
471473
update_model_details=UpdateModelDetails(
472474
custom_metadata_list=updated_custom_metadata_list,
473475
freeform_tags=evaluation_model_freeform_tags,
474-
defined_tags=evaluation_model_defined_tags,
475476
),
476477
)
477478

docs/source/release_notes.rst

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,23 @@
22
Release Notes
33
=============
44

5+
2.13.3
6+
-------
7+
Release date: March 21, 2025
8+
9+
* Fixed defined tag permission issue when creating AI Quick Action fine-tuning and evaluation.
10+
11+
512
2.13.2
613
-------
7-
Release date: March 14th, 2025
14+
Release date: March 14, 2025
815

916
* Fixed bug in DataScienceModel defined metadata.
1017

1118

1219
2.13.1
1320
-------
14-
Release date: March 13th, 2025
21+
Release date: March 13, 2025
1522

1623

1724
* Upgraded OCI SDK to ``v2.148.0`` for improved compatibility and performance.
@@ -35,21 +42,21 @@ Release date: March 13th, 2025
3542

3643
2.13.0
3744
-------
38-
Release date: Feb 14th, 2025
45+
Release date: Feb 14, 2025
3946

4047
* Fixed bug in DataScienceModel defined metadata where non-predefined metadata keys caused errors.
4148

4249

4350
2.12.11
4451
-------
45-
Release date: Feb 5th, 2025
52+
Release date: Feb 5, 2025
4653

4754
* Fixed bug while loading model configuration in AI Quick Actions.
4855

4956

5057
2.12.10
5158
-------
52-
Release date: Feb 5th, 2025
59+
Release date: Feb 5, 2025
5360

5461
* Support inference container URI to be edited for unverified models in AI Quick Actions.
5562
* Logging improvements for all CRUD operations in AI Quick Actions.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ build-backend = "flit_core.buildapi"
2121

2222
# Required
2323
name = "oracle_ads" # the install (PyPI) name; name for local build in [tool.flit.module] section below
24-
version = "2.13.2"
24+
version = "2.13.3"
2525

2626
# Optional
2727
description = "Oracle Accelerated Data Science SDK"

0 commit comments

Comments
 (0)