Skip to content

Commit b890243

Browse files
Fixing UTs
1 parent ce46cf7 commit b890243

File tree

8 files changed

+291
-260
lines changed

8 files changed

+291
-260
lines changed

ads/aqua/app.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -461,9 +461,9 @@ def get_container_config_item(
461461
"""
462462

463463
aqua_container_config = self.get_container_config()
464-
inference_config = aqua_container_config.to_dict().get("inference")
465-
ft_config = aqua_container_config.to_dict().get("finetune")
466-
eval_config = aqua_container_config.to_dict().get("evaluate")
464+
inference_config = aqua_container_config.inference.values()
465+
ft_config = aqua_container_config.finetune.values()
466+
eval_config = aqua_container_config.evaluate.values()
467467
container = next(
468468
(
469469
container

ads/aqua/config/container_config.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,8 @@ def from_service_config(
166166
spec=None,
167167
)
168168
container_type = container.family_name
169-
if container.usages[0].lower() in "inference":
169+
usages = [x.upper() for x in container.usages]
170+
if "INFERENCE" in usages or "MULTI_MODEL" in usages:
170171
container_item.platforms.append(
171172
container.workload_configuration_details_list[
172173
0
@@ -228,11 +229,11 @@ def from_service_config(
228229
),
229230
)
230231
container_item.spec = container_spec
231-
if "INFERENCE" in (x.upper() for x in container.usages):
232+
if "INFERENCE" in usages or "MULTI_MODEL" in usages:
232233
inference_items[container_type] = container_item
233-
if "FINE_TUNE" in (x.upper() for x in container.usages):
234+
if "FINE_TUNE" in usages:
234235
finetune_items[container_type] = container_item
235-
if "EVALUATION" in (x.upper() for x in container.usages):
236+
if "EVALUATION" in usages:
236237
evaluate_items[container_type] = container_item
237238
return cls(
238239
inference=inference_items, finetune=finetune_items, evaluate=evaluate_items

ads/aqua/model/model.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def create_multi(
273273
supported_container_families = [
274274
container_config_item.family
275275
for container_config_item in service_inference_containers
276-
if Usage.MULTI_MODEL in container_config_item.usages
276+
if Usage.MULTI_MODEL.upper() in container_config_item.usages
277277
]
278278

279279
if not supported_container_families:

ads/aqua/modeldeployment/deployment.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
load_gpu_shapes_index,
3535
validate_cmd_var,
3636
)
37-
from ads.aqua.config.container_config import AquaContainerConfig, Usage
37+
from ads.aqua.config.container_config import Usage
3838
from ads.aqua.constants import (
3939
AQUA_MODEL_ARTIFACT_FILE,
4040
AQUA_MODEL_TYPE_CUSTOM,
@@ -225,16 +225,12 @@ def create(
225225
except ConfigValidationError as err:
226226
raise AquaValueError(f"{err}") from err
227227

228-
service_inference_containers = (
229-
AquaContainerConfig.from_container_index_json(
230-
config=container_config
231-
).inference.values()
232-
)
228+
service_inference_containers = container_config.inference.values()
233229

234230
supported_container_families = [
235231
container_config_item.family
236232
for container_config_item in service_inference_containers
237-
if Usage.MULTI_MODEL in container_config_item.usages
233+
if Usage.MULTI_MODEL.upper() in container_config_item.usages
238234
]
239235

240236
if not supported_container_families:

0 commit comments

Comments
 (0)