Skip to content

Commit fee1202

Browse files
committed
feat: addressing PR comments
1 parent c3cd4fd commit fee1202

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ export default class Generate extends Command {
313313
const databaseSID = flags['db-sid'] ?? '';
314314
const databaseServiceName = flags['db-service-name'] ?? '';
315315
const databaseUsername = flags['db-username'] ?? '';
316-
const sqlclPath = flags['sql-cl'] ?? '';
316+
const sqlclPath = flags['sqlcl'] ?? '';
317317

318318
// TODO: Validate and use wallet path
319319
const walletPathDirectory = flags['wallet-path'] ? flags['wallet-path'] : '';
@@ -380,6 +380,7 @@ export default class Generate extends Command {
380380
description: 'This creates an empty project with MLE and Oracle database connection starter code.'
381381
},
382382
],
383+
pageSize: 10,
383384
default: 'node-vanilla'
384385
},
385386
) : template;

templates/mle-ts-sample/README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,12 @@ CREATE OR REPLACE PACKAGE BODY user_package AS
191191
END user_package;
192192

193193
-- Call MLE functions via the user_package in SQL*Plus or SQLcl
194-
EXECUTE USER_PACKAGE.NEWUSERFUNC('EMILY');
194+
DECLARE
195+
userId NUMBER;
196+
BEGIN
197+
userId := USER_PACKAGE.NEWUSERFUNC('EMILY');
198+
DBMS_OUTPUT.PUT_LINE(userId);
199+
END;
195200

196201
SELECT USER_PACKAGE.GETUSER(5);
197202

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
drop table todo_list;
2-
drop table categories;
3-
drop table users;
1+
drop table todo_list CASCADE CONSTRAINTS PURGE;
2+
drop table categories CASCADE CONSTRAINTS PURGE;
3+
drop table users CASCADE CONSTRAINTS PURGE;
4+
45
EXIT;

0 commit comments

Comments
 (0)