[GR-62533] Use Arrays.equals in ByteArraySequence.equals.

PullRequest: graal/20150

Author: woess

sdk/src/org.graalvm.polyglot/src/org/graalvm/polyglot/io/ByteArraySequence.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -83,8 +83,7 @@ public byte[] toByteArray() {
     public boolean equals(Object obj) {
         if (this == obj) {
             return true;
-        } else if (obj instanceof ByteArraySequence) {
-            ByteArraySequence other = ((ByteArraySequence) obj);
+        } else if (obj instanceof ByteArraySequence other) {
             if (buffer == other.buffer) {
                 return start == other.start && length == other.length;
             }
@@ -97,15 +96,10 @@ public boolean equals(Object obj) {
                 // hash was already computed and hash is not equal
                 return false;
             }
-            int otherStart = other.start;
-            for (int i = 0; i < length; i++) {
-                if (buffer[start + i] != other.buffer[otherStart + i]) {
-                    return false;
-                }
-            }
-            return true;
-        } else if (obj instanceof ByteSequence) {
-            ByteSequence other = ((ByteSequence) obj);
+            return Arrays.equals(
+                            this.buffer, this.start, this.start + this.length,
+                            other.buffer, other.start, other.start + other.length);
+        } else if (obj instanceof ByteSequence other) {
             if (length != other.length()) {
                 return false;
             }

truffle/src/com.oracle.truffle.api.benchmark/src/com/oracle/truffle/api/benchmark/ByteSequenceBenchmark.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -84,4 +84,27 @@ public int testHashing(HashingState state) {
         return hash;
     }
 
+    @State(Scope.Thread)
+    public static class EqualsState {
+        final ByteSequence[] sequences = new ByteSequence[ITERATIONS];
+        private final byte[] buffer = new byte[4096];
+        {
+            for (int i = 0; i < buffer.length; i++) {
+                buffer[i] = (byte) i;
+            }
+            for (int i = 0; i < sequences.length; i++) {
+                sequences[i] = ByteSequence.create(buffer.clone());
+            }
+        }
+    }
+
+    @Benchmark
+    @OperationsPerInvocation(ITERATIONS)
+    public int testEquals(EqualsState state) {
+        int check = 0;
+        for (int i = 0; i < state.sequences.length - 1; i++) {
+            check += state.sequences[i].equals(state.sequences[i + 1]) ? 1 : 0;
+        }
+        return check;
+    }
 }