Add edition support in Thin Mode

Author: sharadraju

doc/src/api_manual/oracledb.rst

@@ -853,18 +853,17 @@ Each of the configuration properties is described below.
 
     See :ref:`Edition-Based Redefinition <ebr>` for more information.
 
-    .. note::
-
-        This property can only be used in the node-oracledb Thick mode. See
-        :ref:`enablingthick`.
-
     **Example**
 
     .. code-block:: javascript
 
         const oracledb = require('oracledb');
         oracledb.edition = 'ed_2';
 
+    .. versionchanged:: 6.8
+
+        Support for this property was added in node-oracledb Thin mode.
+
 .. attribute:: oracledb.errorOnConcurrentExecute
 
     .. versionadded:: 5.2

doc/src/release_notes.rst

@@ -20,6 +20,9 @@ Common Changes
 Thin Mode Changes
 +++++++++++++++++
 
+#)  Added support for setting the :attr:`~oracledb.edition` when connecting to
+    the database.
+
 #)  Fixed error message in ``NJS-131`` to provide the correct range of the
     database object collection types.
 

doc/src/user_guide/appendix_a.rst

@@ -153,7 +153,7 @@ node-oracledb Thin and Thick modes. For more details see :ref:`modediff`.
       - Yes - Out-of-Band (OOB) Connection Breaks not supported
       - Yes
     * - Edition Based Redefinition (EBR) (see :ref:`ebr`)
-      - No
+      - Yes
       - Yes
     * - SQL execution (see :ref:`sqlexecution`)
       - Yes

doc/src/user_guide/plsql_execution.rst

@@ -213,15 +213,15 @@ updated and tested while production users are still accessing the
 original version. Once every user has begun using the objects in the new
 edition, the old objects can be dropped.
 
-.. note::
-
-    In this release, Edition-Based Redefinition is only supported in the
-    node-oracledb Thick mode. See :ref:`enablingthick`.
-
 To choose the edition, node-oracledb applications can set
 :attr:`oracledb.edition` globally, or specify a value
 when :ref:`creating a pool <createpoolpoolattrsedition>` or a
-:ref:`standalone connection <getconnectiondbattrsedition>`.
+:ref:`standalone connection <getconnectiondbattrsedition>`. You can also set
+the edition by using the ``ORA_EDITION`` environment variable. The edition
+value set as part of the connection parameters in
+:meth:`oracledb.createPool()` or :meth:`oracledb.getConnection()` takes
+precedence over the values specified in the :attr:`oracledb.edition` property
+or the ``ORA_EDITION`` environment variable.
 
 The example below shows how a PL/SQL function ``DISCOUNT`` can be
 created with two different implementations. The initial procedure is

lib/thin/protocol/messages/auth.js

@@ -107,6 +107,11 @@ class AuthMessage extends Message {
     this.osUser = config.osUser;
     this.program = config.program;
     this.terminal = config.terminal;
+    if (config.edition) {
+      this.edition = config.edition;
+    } else if (process.env.ORA_EDITION) {
+      this.edition = process.env.ORA_EDITION;
+    }
     this.setAuthMode(config);
   }
 
@@ -235,6 +240,9 @@ class AuthMessage extends Message {
           this.encryptedJDWPData = ED.getEncryptedJSWPData(this.sessionKey, this.conn.jdwpData);
           numPairs += 1;
         }
+        if (this.edition) {
+          numPairs += 1;
+        }
         if (this.schemaUser.length !== 0) {
           numPairs += 1;
         }
@@ -297,6 +305,9 @@ class AuthMessage extends Message {
       if (this.conn.jdwpData) {
         buf.writeKeyValue("AUTH_ORA_DEBUG_JDWP", this.encryptedJDWPData);
       }
+      if (this.edition) {
+        buf.writeKeyValue("AUTH_ORA_EDITION", this.edition);
+      }
 
     }
   }

test/editionTest.js

@@ -65,11 +65,11 @@ describe('160. editionTest.js', function() {
 
   before(async function() {
 
-    let isRunnable = Boolean(!oracledb.thin && dbConfig.test.DBA_PRIVILEGE
-      && !dbConfig.test.drcp && !(await testsUtil.cmanTdmCheck()));
+    let isRunnable = dbConfig.test.DBA_PRIVILEGE && !dbConfig.test.drcp
+      && !(await testsUtil.cmanTdmCheck());
     if (isRunnable) {
       const connection = await oracledb.getConnection(dbConfig);
-      if (connection.oracleServerVersion < 1202000100) {
+      if (connection.oracleServerVersion < 1201000200) {
         isRunnable = false;
       }
       await connection.close();