Skip to content

Commit 99b809f

Browse files
committed
improve tagging
1 parent 9ad4c4b commit 99b809f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/cloudprovider/providers/oci/instances.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func (cp *CloudProvider) extractNodeAddresses(ctx context.Context, instanceID st
100100

101101
secondaryVnic, err := cp.client.Compute().GetSecondaryVNICForInstance(ctx, compartmentID, instanceID)
102102
if err != nil {
103-
return nil, errors.Wrap(err, "GetSecondaryVNICForInstance")
103+
return addresses, nil
104104
}
105105

106106
if secondaryVnic == nil {
@@ -124,6 +124,7 @@ func (cp *CloudProvider) extractNodeAddresses(ctx context.Context, instanceID st
124124
addresses = append(addresses, api.NodeAddress{Type: api.NodeExternalIP, Address: ip.String()})
125125
}
126126
}
127+
127128
// Changing this can have wide reaching impact.
128129
//
129130
// if vnic.HostnameLabel != nil && *vnic.HostnameLabel != "" {

pkg/cloudprovider/providers/oci/node_info_controller.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,9 @@ import (
4141

4242
// metadata labeling for placement info
4343
const (
44-
FaultDomainLabel = "oci.oraclecloud.com/fault-domain"
45-
CompartmentIDAnnotation = "oci.oraclecloud.com/compartment-id"
46-
OpenShiftNodeIdentifierLabel = "node.openshift.io/os_id"
47-
timeout = 10 * time.Second
44+
FaultDomainLabel = "oci.oraclecloud.com/fault-domain"
45+
CompartmentIDAnnotation = "oci.oraclecloud.com/compartment-id"
46+
timeout = 10 * time.Second
4847
)
4948

5049
// NodeInfoController helps compute workers in the cluster

0 commit comments

Comments
 (0)