Skip to content

Commit 0b0c67d

Browse files
committed
Fix comments from review
1 parent db66f12 commit 0b0c67d

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ and **Merged pull requests**. Critical items to know are:
1414
The versions coincide with releases on pip. Only major versions will be released as tags on Github.
1515

1616
## [0.0.x](https://github.com/oras-project/oras-py/tree/main) (0.0.x)
17-
- use same annotation as oras-go for determining whether to unpack a layer or not (0.2.26)
1817
- check for blob existence before uploading (0.2.26)
1918
- fix get_tags for ECR when limit is None, closes issue [173](https://github.com/oras-project/oras-py/issues/173)
2019
- fix empty token for anon tokens to work, closes issue [167](https://github.com/oras-project/oras-py/issues/167)
20+
- use same annotation as oras-go for determining whether to unpack a layer or not [119](https://github.com/oras-project/oras-py/issues/119)
2121
- retry on 500 (0.2.25)
2222
- align provider config_path type annotations (0.2.24)
2323
- add missing prefix property to auth backend (0.2.23)

oras/provider.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -888,8 +888,6 @@ def pull(
888888
:type overwrite: bool
889889
:param outdir: output directory path
890890
:type outdir: str
891-
:param skip_unpack: skip unpacking layers
892-
:type skip_unpack: bool
893891
"""
894892
container = self.get_container(target)
895893
self.auth.load_configs(
@@ -906,9 +904,6 @@ def pull(
906904
# A directory will need to be uncompressed and moved
907905
unpack_layer = annotations.get(oras.defaults.annotation_unpack, False)
908906

909-
if unpack_layer and skip_unpack:
910-
filename += ".tar.gz"
911-
912907
# If we don't have a filename, default to digest. Hopefully does not happen
913908
if not filename:
914909
filename = layer["digest"]
@@ -922,7 +917,7 @@ def pull(
922917
)
923918
continue
924919

925-
if unpack_layer and not skip_unpack:
920+
if unpack_layer:
926921
targz = oras.utils.get_tmpfile(suffix=".tar.gz")
927922
self.download_blob(container, layer["digest"], targz)
928923

0 commit comments

Comments
 (0)