test: refactor so that all vm related tests can be reused [HMS-9572] #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
requested review from
achilleas-k,
supakeen and
thozza
and removed request for
a team
mvo5
force-pushed
the
vmtest-as-py-package
branch
from
841a503 to
0a5c722
Compare
mvo5
force-pushed
the
vmtest-as-py-package
branch
from
9fc525f to
450b042
Compare
achilleas-k
previously approved these changes
Nov 7, 2025
Member
|
There are a bunch of pylint errors here, can those be addressed? |
mvo5
force-pushed
the
vmtest-as-py-package
branch
3 times, most recently
from
50326a5 to
5e47a88
Compare
This commit reshuffles the code a bit so that we a reusable ./test/vmtest directory that can be used by the images library. With that we can add a toplevel pyproject.toml file so that we can import vmtest via ```console $ pip install [email protected]/osbuild/bootc-image-builder ``` im other projects. Note that none of this is ideal, butt this is (hopefully) a temporary measure until we find a more permanent home for our vm runner or replace it with something like test.thing or the new osbuild QEMU code.
mvo5
force-pushed
the
vmtest-as-py-package
branch
from
5e47a88 to
64aafc0
Compare
mvo5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reshuffles the code a bit so that we a reusable ./vmtest directory that can be used by the images library.
With that we can add a toplevel pyproject.toml file so that we can import vmtest via
$ pip install [email protected]/osbuild/bootc-image-builderim other projects.
Note that none of this is ideal, I wish python would be more like go here and make this easier, I dislike that we have to have the pyproject in a toplevel dir. But this is (hopefully) a temporary measure until we find a more permanent home for our vm runner or replace it with something like test.thing or the new osbuild QEMU code.