components: Ensure deleting a blueprint also deletes any associated images #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexowl
force-pushed
the
delete-images-together-with-blueprint
branch
3 times, most recently
from
7271a1c
to
041adf1
Compare
regexowl
force-pushed
the
delete-images-together-with-blueprint
branch
2 times, most recently
from
b9b74cd
to
06abcab
Compare
jkozol
requested changes
Feb 9, 2023
There was a problem hiding this comment.
This works as expected :)
But can you create a filtered thunk for deletion in the images. That way we can dispatch an action to delete filtered images more generally. This also would mean the deleteDlueprint thunk will only have to dispatch a single action instead of loop dispatching actions.
…mages Fixes osbuild#1694. This adds a deletion of any associated images when a blueprint is deleted. Copy for the modal was also updated to inform the user that the images will be deleted together with the blueprint.
regexowl
force-pushed
the
delete-images-together-with-blueprint
branch
from
06abcab
to
4f65880
Compare
|
@jkozol Updated. Please let me know if it's similar to what you had in mind. |
|
@jkozol This PR might also be a bit stale. Should I close it? |
|
Closing this PR as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1694.
This adds a deletion of any associated images when a blueprint is deleted.
Copy for the modal was also updated to inform the user that the images will be deleted together with the blueprint.