store/cockpit: delete cloud config

The image-builder cli handles the the available target clouds based on
environment variables set on the host. For example, if configs and
credentials exist in `~/.aws`, then aws image types will be surfaced as
available image types.

We will need a way to provide the image-build with the name of the
aws bucket, so we need to add this as an option in the AWS step of the
wizard.

Author: kingsleyzissou

.github/workflows/unit-tests.yml

@@ -38,13 +38,17 @@ jobs:
   cockpit-unit-tests:
     name: Cockpit Tests
     runs-on: ubuntu-latest
+    container:
+      image: registry.fedoraproject.org/fedora:42
     steps:
     - uses: actions/checkout@v4
     - name: Use Node.js 22
       uses: actions/setup-node@v4
       with:
         node-version: 22
         cache: 'npm'
+    - name: 'Install image builder'
+      run: 'dnf install -y image-builder'
     - name: Install dependencies
       run: npm ci
     - name: Run unit tests with cockpit

playwright/test.spec.ts

@@ -1,21 +1,10 @@
-import { readFileSync, writeFileSync } from 'node:fs';
-import os from 'node:os';
-import path from 'node:path';
-
-import TOML from '@ltd/j-toml';
 import { expect, test } from '@playwright/test';
 import { v4 as uuidv4 } from 'uuid';
 
 import { closePopupsIfExist, isHosted } from './helpers/helpers';
 import { ensureAuthenticated } from './helpers/login';
 import { ibFrame, navigateToLandingPage } from './helpers/navHelpers';
 
-const awsCredentials = `
-[default]
-aws_access_key_id = supersecret
-aws_secret_access_key = secretsquirrel
-`;
-
 test.describe.serial('test', () => {
   const blueprintName = uuidv4();
   test('create blueprint', async ({ page }) => {
@@ -191,96 +180,12 @@ test.describe.serial('test', () => {
     await frame.getByRole('button', { name: 'Delete' }).click();
   });
 
-  test('cockpit worker config', async ({ page }) => {
-    if (isHosted()) {
-      return;
-    }
-
-    await ensureAuthenticated(page);
-    await closePopupsIfExist(page);
-    // Navigate to IB landing page and get the frame
-    await navigateToLandingPage(page);
-    await page.goto('/cockpit-image-builder');
-    const frame = ibFrame(page);
-
-    const header = frame.getByText('Configure AWS Uploads');
-    if (!(await header.isVisible())) {
-      await frame
-        .getByRole('button', { name: 'Configure Cloud Providers' })
-        .click();
-      await expect(header).toBeVisible();
-    }
-
-    const bucket = 'cockpit-ib-playwright-bucket';
-    const credentials = '/test/credentials';
-    const switchInput = frame.locator('#aws-config-switch');
-    await expect(switchInput).toBeVisible();
-
-    // introduce a wait time, since it takes some time to load the
-    // worker config file.
-    await page.waitForTimeout(1000);
-
-    // If this test fails for any reason, the config should already be loaded
-    // and visible on the retury. If it is go back to the landing page
-    if (await switchInput.isChecked()) {
-      await frame.getByRole('button', { name: 'Cancel' }).click();
-      await expect(
-        frame.getByRole('heading', { name: 'All images' }),
-      ).toBeVisible();
-    } else {
-      const switchToggle = frame.locator('.pf-v6-c-switch');
-      await switchToggle.click();
-
-      await frame
-        .getByPlaceholder('AWS bucket')
-        // this doesn't need to exist, we're just testing that
-        // the form works as expected
-        .fill(bucket);
-      await frame.getByPlaceholder('Path to AWS credentials').fill(credentials);
-      await frame.getByRole('button', { name: 'Submit' }).click();
-      await expect(
-        frame.getByRole('heading', { name: 'All images' }),
-      ).toBeVisible();
-    }
-
-    await frame
-      .getByRole('button', { name: 'Configure Cloud Providers' })
-      .click();
-    await expect(header).toBeVisible();
-
-    // introduce a wait time, since it takes some time to load the
-    // worker config file.
-    await page.waitForTimeout(1500);
-
-    await expect(frame.locator('#aws-config-switch')).toBeChecked();
-
-    await expect(frame.getByPlaceholder('AWS bucket')).toHaveValue(bucket);
-    await expect(frame.getByPlaceholder('Path to AWS credentials')).toHaveValue(
-      credentials,
-    );
-    await frame.getByRole('button', { name: 'Cancel' }).click();
-
-    const config = readFileSync('/etc/osbuild-worker/osbuild-worker.toml');
-    // this is for testing, the field `aws` should exist
-    // eslint-disable-next-line
-    const parsed = TOML.parse(config.toString()) as any;
-    expect(parsed.aws?.bucket).toBe(bucket);
-    expect(parsed.aws?.credentials).toBe(credentials);
-  });
-
   const cockpitBlueprintname = uuidv4();
   test('cockpit cloud upload', async ({ page }) => {
     if (isHosted()) {
       return;
     }
 
-    // this needs to be set so ibcli will list aws targets
-    // as an available image type
-    writeFileSync(
-      path.join(os.homedir(), '.aws', 'credentials'),
-      awsCredentials,
-    );
-
     await ensureAuthenticated(page);
     await closePopupsIfExist(page);
     // Navigate to IB landing page and get the frame
@@ -296,6 +201,11 @@ test.describe.serial('test', () => {
     // the first card should be the AWS card
     await frame.locator('.pf-v6-c-card').first().click();
     await frame.getByRole('button', { name: 'Next', exact: true }).click();
+    await frame
+      .getByPlaceholder('AWS bucket')
+      // this doesn't need to exist, we're just testing that
+      // the form works as expected
+      .fill('some-random-bucket');
     await frame.getByRole('button', { name: 'Next', exact: true }).click();
     await frame.getByRole('button', { name: 'Review and finish' }).click();
     await frame.getByRole('button', { name: 'Back', exact: true }).click();

schutzbot/Containerfile-Playwright

@@ -4,7 +4,7 @@ set -euo pipefail
 source /etc/os-release
 
 sudo dnf install -y \
-     libappstream-glib
+     libappstream-glib image-builder
 
 if [[ "$ID" == rhel && ${VERSION_ID%.*} == 10 ]]; then
     sudo dnf install -y nodejs-npm \

schutzbot/make_rpm_and_install.sh

@@ -21,8 +21,6 @@ sudo useradd admin -p "$(openssl passwd foobar)"
 sudo usermod -aG wheel admin
 echo "admin ALL=(ALL:ALL) NOPASSWD: ALL" | sudo tee "/etc/sudoers.d/admin-nopasswd"
 
-sudo podman build --tag playwright -f $(pwd)/schutzbot/Containerfile-Playwright .
-
 function upload_artifacts {
     if [ -n "${TMT_TEST_DATA:-}" ]; then
         mv playwright-report "$TMT_TEST_DATA"/playwright-report
@@ -76,6 +74,13 @@ EOF
 sudo systemctl enable --now osbuild-composer.socket osbuild-local-worker.socket
 sudo systemctl start osbuild-worker@1
 
+sudo mkdir -p $HOME/.aws
+cat <<EOF | sudo tee -a $HOME/.aws/credentials
+[default]
+aws_access_key_id = supersecret
+aws_secret_access_key = secretsquirrel
+EOF
+
 sudo podman run \
      -e "PLAYWRIGHT_HTML_OPEN=never" \
      -e "CI=true" \
@@ -90,5 +95,5 @@ sudo podman run \
      --privileged  \
      --rm \
      --init \
-     localhost/playwright \
+     mcr.microsoft.com/playwright:v1.51.1-noble \
      /bin/sh -c "cd tests && npx -y [email protected] test --workers=${PW_WORKERS}"