Train route presets inappropriately change type of train

[jarek]

See discussion in https://community.openstreetmap.org/t/bad-name-suggestions-for-train-routes-in-spain-problem-with-preset-or-with-the-concept/125234/5. Excerpt:

It looks like iD’s preset-matching code is getting confused because both the Commuter and InterCity presets have the same operator tags. The code to match presets goes way over my head, but my understanding is that it doesn’t know the network tags are more relevant than the operator tags. Instead, it breaks ties based on the number of matching tags. The presence of both operator:en=* and operator:ga=* probably exacerbates the issue.

For better or worse, NSI’s architecture assumes that a feature is identified by one of brand, operator, network, or flag, but not a combination. This makes it difficult to standardize more than one of these attributes at the same time, even if they all have Wikidata items. In an ideal world, the presets would be scoped to individual fields rather than the whole feature – this is still a railway, not “a” Commuter. But iD hasn’t had any facility for “field presets” ever since NSI grew into more than just a name=* suggestion index. In the past, some presets have had to get trimmed down to avoid this sort of conflict.

As an example, iD ends up suggesting changing an Irish Commuter route to an InterCity route:

[linesinalandscape]

Just to add:

Irish Rail is the only train operator in the Republic of Ireland, so all train routes will correctly be tagged with that operator. In a city such as Cork with both types of train running on the same tracks, there seems no reason to prompt the mapper to change their original choice.

Similarly, in many Spanish cities, Renfe operates both a "Cercanías" commuter network and longer routes. I have cleaned up routes where mappers were confused by the suggested "upgrade'' and applied the suggested Cercanías tags to long distance trains.(That was what prompted me to start looking at this).

[Snowysauce]

This is probably related to #9996 (comment) and #10167 (comment), in which case the issue lies with iD, not the NSI.

[jarek]

Thank you for the pointer. I created the issue for iD openstreetmap/id-tagging-schema#1437