Merge pull request #139 from PikachuEXE/connection_pool_3-both

Test against connection_pool 2.x too

Author: benubois

.github/workflows/ci.yml

@@ -8,6 +8,11 @@ jobs:
     strategy:
       matrix:
         ruby-version: ['3.2', '3.3', '3.4', '4.0']
+        gemfile:
+          - gemfiles/connection_pool_2.gemfile
+          - gemfiles/connection_pool_3.gemfile
+    env:
+      BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
     steps:
     - uses: actions/checkout@v6
     - name: Set up Ruby

gemfiles/connection_pool_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "connection_pool", "~> 2"
+
+gemspec path: "../"

gemfiles/connection_pool_3.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "connection_pool", "~> 3"
+
+gemspec path: "../"

spec/apnotic/connection_pool_spec.rb

@@ -9,7 +9,8 @@
 
   let(:pool_options) do
     {
-      size: 5
+      # Using 6 since default value is 5 in both 2.x & 3.x
+      size: 6
     }
   end
 
@@ -35,7 +36,7 @@
 
       it "returns a connection pool" do
         expect(subject).to be_kind_of(::ConnectionPool)
-        expect(subject.size).to eq(5)
+        expect(subject.size).to eq(6)
       end
 
       it "passes the connection into a block" do