Use cache to improve cloud-report performance

We want to report to cloud only if there was a change in the webhooks
services

Author: zohar7ch

src/mapper/pkg/config/config.go

@@ -39,7 +39,7 @@ const (
 	MetricsCollectionTrafficCacheSizeKey     = "metrics-collection-traffic-cache-size"
 	MetricsCollectionTrafficCacheSizeDefault = 10000
 	WebhookServicesCacheSizeKey              = "webhook-services-cache-size"
-	WebhookServicesCacheSizeDefault          = 10000
+	WebhookServicesCacheSizeDefault          = 10
 
 	EnableIstioCollectionKey                  = "enable-istio-collection"
 	EnableIstioCollectionDefault              = false

src/mapper/pkg/webhook_traffic/webhook_services_cache.go

@@ -30,21 +30,25 @@ func NewWebhookServicesCache() *WebhookServicesCache {
 	}
 }
 
-func (c *WebhookServicesCache) Get(namespace string, serviceName string, webhookName string, webhookType cloudclient.WebhookType) (CacheValue, bool) {
-	return c.cache.Get(c.key(namespace, serviceName, webhookName, webhookType))
+func (c *WebhookServicesCache) Get() (CacheValue, bool) {
+	return c.cache.Get("webhooks")
 }
 
-func (c *WebhookServicesCache) Set(namespace string, serviceName string, webhookName string, webhookType cloudclient.WebhookType, value CacheValue) bool {
-	return c.cache.Add(c.key(namespace, serviceName, webhookName, webhookType), value)
+func (c *WebhookServicesCache) Set(value CacheValue) bool {
+	return c.cache.Add("webhooks", value)
 }
 
-func (c *WebhookServicesCache) key(namespace string, serviceName string, webhookName string, webhookType cloudclient.WebhookType) string {
-	return fmt.Sprintf("%s#%s#%s#%s", namespace, serviceName, webhookName, webhookType)
+func K8sWebhookServiceInputKey(webhookService cloudclient.K8sWebhookServiceInput) string {
+	return fmt.Sprintf("%s#%s#%s#%s",
+		webhookService.Identity.Namespace,
+		webhookService.Identity.Name,
+		webhookService.WebhookName,
+		webhookService.WebhookType)
 }
 
 func (c *WebhookServicesCache) GenerateValue(webhookServices []cloudclient.K8sWebhookServiceInput) (CacheValue, error) {
 	values := lo.Map(webhookServices, func(item cloudclient.K8sWebhookServiceInput, _ int) string {
-		return c.key(item.Identity.Namespace, item.Identity.Name, item.WebhookName, item.WebhookType)
+		return K8sWebhookServiceInputKey(item)
 	})
 
 	slices.Sort(values)

src/mapper/pkg/webhook_traffic/webhook_services_handler.go

@@ -1,8 +1,8 @@
 package webhook_traffic
 
 import (
+	"bytes"
 	"context"
-	"fmt"
 	"github.com/otterize/intents-operator/src/shared/errors"
 	"github.com/otterize/network-mapper/src/mapper/pkg/cloudclient"
 	"github.com/otterize/network-mapper/src/mapper/pkg/graph/model"
@@ -58,17 +58,36 @@ func (h *WebhookServicesHandler) HandleAll(ctx context.Context) error {
 	allWebhookServices := append(validatingWebhookServices, mutatingWebhookServices...)
 	allWebhookServices = append(allWebhookServices, conversionWebhookServices...)
 
+	err = h.reportToCloud(ctx, allWebhookServices)
+	if err != nil {
+		return errors.Wrap(err)
+	}
+
+	return nil
+}
+
+func (h *WebhookServicesHandler) reportToCloud(ctx context.Context, allWebhookServices []cloudclient.K8sWebhookServiceInput) error {
 	// dedup
-	allWebhookServices = lo.UniqBy(allWebhookServices, func(service cloudclient.K8sWebhookServiceInput) string {
-		return fmt.Sprintf("%s#%s#%s#%s", service.Identity.Namespace, service.Identity.Name, service.WebhookName, service.WebhookType)
+	allWebhookServices = lo.UniqBy(allWebhookServices, K8sWebhookServiceInputKey)
 
-	})
+	newCacheValue, err := h.cache.GenerateValue(allWebhookServices)
+	if err != nil {
+		return errors.Wrap(err)
+	}
+
+	currentCacheValue, found := h.cache.Get()
+	if found && bytes.Equal(currentCacheValue, newCacheValue) {
+		// current cache value is same as the new one, no need to report
+		return nil
+	}
 
 	err = h.otterizeCloud.ReportK8sWebhookServices(ctx, allWebhookServices)
 	if err != nil {
 		return errors.Wrap(err)
 	}
 
+	h.cache.Set(newCacheValue)
+
 	return nil
 }