let's try keeping it split

Author: lydia-theda

app/models/feedback_reporters/support_reporter.rb

@@ -16,7 +16,7 @@ def custom_zoho_fields
     # To avoid issues where Zoho ticket creation silently fails, only grab the first
     # 2080 characters of the referer URL. That may miss some complex search queries,
     # but still keep enough to be useful most of the time.
-    truncated_referer = url.present? ? url[0..2079] : ""
+    truncated_referer = referer.present? ? referer[0..2079] : ""
     {
       "cf_archive_version" => site_revision.presence || "Unknown site revision",
       "cf_rollout" => rollout.presence || "Unknown",

features/other_b/support.feature

@@ -61,7 +61,7 @@ Feature: Filing a support request
     And the email should not contain "<img src="http://www.example.org/foo.jpg" />"
     But the email should contain "http://www.example.org/foo.jpgHi"
 
-  Scenario: Submit a request with an on-Archive referer URL
+  Scenario: Submit a request with an on-Archive referer
 
   Given I am logged in as "puzzled"
     And basic languages
@@ -72,9 +72,9 @@ Feature: Filing a support request
     And I fill in "Brief summary" with "Just a brief note"
     And I fill in "Your question or problem" with "Hi, I came from the Archive"
     And I press "Send"
-  Then a Zoho ticket should be created with url "http://www.example.com/works"
+  Then a Zoho ticket should be created with referer "http://www.example.com/works"
 
-  Scenario: Submit a request with a referer URL that is not on-Archive
+  Scenario: Submit a request with a referer that is not on-Archive
 
   Given I am logged in as "puzzled"
     And basic languages
@@ -84,4 +84,4 @@ Feature: Filing a support request
     And I fill in "Brief summary" with "Just a brief note"
     And I fill in "Your question or problem" with "Hi, I didn't come from the Archive"
     And I press "Send"
-  Then a Zoho ticket should be created with url ""
+  Then a Zoho ticket should be created with referer ""

features/step_definitions/support_steps.rb

@@ -12,9 +12,9 @@
   allow(ArchiveConfig).to receive(:PERMITTED_HOSTS).and_return([host])
 end
 
-Then "a Zoho ticket should be created with url {string}" do |url|
+Then "a Zoho ticket should be created with referer {string}" do |referer|
   # rubocop:disable Lint/AmbiguousBlockAssociation
   expect(WebMock).to have_requested(:post, "https://desk.zoho.com/api/v1/tickets")
-    .with { |req| JSON.parse(req.body)["cf"]["cf_ticket_url"] == url }
+    .with { |req| JSON.parse(req.body)["cf"]["cf_ticket_url"] == referer }
   # rubocop:enable Lint/AmbiguousBlockAssociation
 end

spec/models/feedback_reporters/support_reporter_spec.rb

@@ -16,7 +16,7 @@
       site_revision: "eternal_beta",
       rollout: "rollout_value",
       ip_address: "127.0.0.1",
-      url: "https://example.com/works/1",
+      referer: "https://example.com/works/1",
       site_skin: build(:skin, title: "Reversi", public: true)
     }
   end
@@ -116,17 +116,17 @@
 
     context "if the report has an empty URL" do
       before do
-        allow(subject).to receive(:url).and_return("")
+        allow(subject).to receive(:referer).and_return("")
       end
 
-      it "returns a hash containing a blank string for URL" do
+      it "returns a hash containing a blank string for referer" do
         expect(subject.report_attributes.dig("cf", "cf_ticket_url")).to eq("")
       end
     end
 
-    context "if the reporter has a very long URL" do
+    context "if the reporter has a very long referer URL" do
       before do
-        allow(subject).to receive(:url).and_return("a" * 2081)
+        allow(subject).to receive(:referer).and_return("a" * 2081)
       end
 
       it "truncates the URL to 2080 characters" do