AO3-5573 Fix sorting on user collected works page

Author: metallicity

app/views/works/_collection_filters.html.erb

@@ -1,4 +1,4 @@
-<%= form_for @search, 
+<%= form_for @search, as: :work_search, 
   url: collected_user_works_path(@user), 
   html: { 
     method: :get, 

features/search/works_collected.feature

@@ -0,0 +1,24 @@
+Feature: Search collected works
+  As a creator of collected works
+  I want to filter for works across all those collections
+
+  Scenario: Works that are collected show up in the creator's
+  collected works page
+    Given I am logged in as "author"
+      And I create the collection "Author Collection"
+      And I create the collection "Other Collection"
+      And I post the work "Old Title" to the collection "Author Collection"
+      And I post the work "Revised Title" to the collection "Author Collection"
+      And I post the work "New Title" to the collection "Other Collection"
+      And I post a chapter for the work "Revised Title"
+    When I go to author's user page
+      And I follow "Works (3)"
+      And I follow "Works in Collections"
+    Then I should see "Works in Challenges/Collections"
+      And "Revised Title" should appear before "New Title"
+      And "New Title" should appear before "Old Title"
+    When I select "Title" from "Sort by"
+      And I press "Sort and Filter"
+    Then I should see "Works in Challenges/Collections"
+      And "New Title" should appear before "Old Title"
+      And "Old Title" should appear before "Revised Title"

spec/controllers/works/default_rails_actions_spec.rb

@@ -815,6 +815,51 @@ def call_with_params(params)
         expect(assigns(:works)).to include(work, unrevealed_work)
       end
     end
+
+    context "with sorting options" do
+      let!(:new_work) do
+        create(:work,
+               title: "New Title",
+               authors: [collected_user.default_pseud],
+               collection_names: collection.name,
+               created_at: 3.days.ago,
+               revised_at: 3.days.ago)
+      end
+
+      let!(:old_work) do
+        create(:work,
+               title: "Old Title",
+               authors: [collected_user.default_pseud],
+               collection_names: collection.name,
+               created_at: 30.days.ago,
+               revised_at: 30.days.ago)
+      end
+
+      let!(:revised_work) do
+        create(:work,
+               title: "Revised Title",
+               authors: [collected_user.default_pseud],
+               collection_names: collection.name,
+               created_at: 20.days.ago,
+               revised_at: 2.days.ago)
+      end
+
+      before { run_all_indexing_jobs }
+
+      it "sorts by date" do
+        get :collected, params: { user_id: collected_user.login }
+        expect(assigns(:works).map(&:title)).to eq([revised_work, new_work, old_work].map(&:title))
+        get :collected, params: { user_id: collected_user.login, work_search: { sort_direction: "asc" } }
+        expect(assigns(:works).map(&:title)).to eq([old_work, new_work, revised_work].map(&:title))
+      end
+
+      it "sorts by title" do
+        get :collected, params: { user_id: collected_user.login, work_search: { sort_column: "title_to_sort_on" } }
+        expect(assigns(:works).map(&:title)).to eq([new_work, old_work, revised_work].map(&:title))
+        get :collected, params: { user_id: collected_user.login, work_search: { sort_column: "title_to_sort_on", sort_direction: "desc" } }
+        expect(assigns(:works).map(&:title)).to eq([revised_work, old_work, new_work].map(&:title))
+      end
+    end
   end
 
   describe "destroy" do