Skip to content

Commit 7f882d1

Browse files
use Float as a stopgap for GraphQL’s number type support
1 parent 0b57cf1 commit 7f882d1

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

Makefile

+7-7
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@ INFO_HEADER := "**************** "
1919

2020
DONE_MESSAGE := $(YELLOW)$(INFO_HEADER) "- done\n" $(END)
2121

22-
2322
# Variables
2423
DOCKER_DIR := $(ROOT_DIR)/docker
2524
ES_DATA_DIR := $(DOCKER_DIR)/elasticsearch
26-
# ES_DOCS_DIR can be given with a custom directory for docs to be seeded
25+
ES_DOCS_DIR := $(ES_DATA_DIR)/documents
2726
ES_HOST := http://localhost:9200
2827
ES_INDEX := file_centric_1.0
2928
ES_LOAD_SCRIPT := $(ES_DATA_DIR)/load-es-data.sh
@@ -36,10 +35,11 @@ ES_BASIC_AUTH := $(shell printf "$(ES_USER):$(ES_PASS)" | base64)
3635

3736
# Commands
3837
DOCKER_COMPOSE_CMD := \
39-
ES_USER=$(ES_USER) \
38+
ES_USER=$(ES_USER) \
4039
ES_PASS=$(ES_PASS) \
41-
$(DOCKER_COMPOSE_EXE) -f \
40+
$(DOCKER_COMPOSE_EXE) -f \
4241
$(ROOT_DIR)/docker-compose.yml
42+
4343
DC_UP_CMD := COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 $(DOCKER_COMPOSE_CMD) up -d --build
4444

4545

@@ -49,9 +49,9 @@ DC_UP_CMD := COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 $(DOCKER_COMPOSE_CMD)
4949
_ping_elasticsearch_server:
5050
@echo $(YELLOW)$(INFO_HEADER) "Pinging ElasticSearch on $(ES_HOST)" $(END)
5151
@sh $(RETRY_CMD) "curl --retry 10 \
52-
--retry-delay 0 \
53-
--retry-max-time 40 \
54-
--retry-connrefuse \
52+
--retry-delay 0 \
53+
--retry-max-time 40 \
54+
--retry-connrefused \
5555
-H \"Authorization: Basic $(ES_BASIC_AUTH)\" \
5656
\"$(ES_HOST)/_cluster/health?wait_for_status=yellow&timeout=100s&wait_for_no_initializing_shards=true\""
5757
@echo ""

docker/Dockerfile.jenkins.dockerignore

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ docks
66
integration-tests
77
modules/**/*
88
!modules/server
9-
scripts
109
Jenkinsfile
1110
lerna*
1211
prettier*

modules/server/src/mapping/mappingToScalarFields.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ export let esToGraphqlTypeMap = {
55
double: 'Float',
66
float: 'Float',
77
half_float: 'Float',
8-
integer: 'Int',
8+
integer: 'Float',
99
keyword: 'String',
10-
long: 'Int',
10+
long: 'Float', // hack to compensate for graphql not supporting Long. TODO: add a Long custom type https://github.com/overture-stack/arranger/issues/796
1111
object: 'JSON', // https://github.com/overture-stack/arranger/blob/master/modules/schema/src/index.js#L9
1212
scaled_float: 'Float',
1313
string: 'String',

0 commit comments

Comments
 (0)