Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-scripts-ts to new CRA #108

Open
6 of 9 tasks
anncatton opened this issue Jan 11, 2021 · 3 comments
Open
6 of 9 tasks

Upgrade react-scripts-ts to new CRA #108

anncatton opened this issue Jan 11, 2021 · 3 comments
Assignees
@anncatton
Labels
4.3.0 canarie major High Priority SP:5 Issue is estimated at 5 story points

Comments

@anncatton
Copy link
Contributor

anncatton commented Jan 11, 2021 •
edited
Loading

react-scripts-ts has been replaced by a newer version of Create React App + Typescript, and should be upgraded to latest react-scripts. This will also fix some issues with its out-of-date dependencies that dependabot is complaining about.
Work on this ticket may include:

  • updating to react-scripts 4.x.x
  • fixing minor linter warnings
  • updating react-router-dom to fix outdated React lifecycle methods
  • updating semantic-ui-react to fix outdated React lifecycle methods
  • replace freactal state to fix outdated React lifecycle methods
  • replace recompose methods with hooks to fix outdated React lifecycle methods
  • fix typing when tsconfig is set to strict mode
  • replace glamor dependency as it has a vulnerability and is no longer maintained
  • remove storybook (to be replaced with new version setup in Add storybook #159 )
@anncatton anncatton self-assigned this Jan 11, 2021
@anncatton anncatton mentioned this issue Jan 11, 2021
Closed
@b-f-chan b-f-chan added canarie major High Priority labels Feb 22, 2021
@b-f-chan b-f-chan added this to the Canarie Sprint 16 milestone Feb 22, 2021
@anncatton anncatton added the SP:5 Issue is estimated at 5 story points label Feb 22, 2021
@b-f-chan b-f-chan added this to the Canarie Sprint 17 milestone Mar 26, 2021
@anncatton anncatton mentioned this issue Apr 7, 2021
Open
@b-f-chan
Copy link

b-f-chan commented Apr 8, 2021

These two sub-tasks will be handled separately:

  • Replace freactal state : ego-ui#161
  • Replace recompose methods : ego-ui#162

@anncatton anncatton mentioned this issue Apr 15, 2021
Open
@b-f-chan b-f-chan removed this from the Canarie Sprint 17 milestone May 2, 2021
@anncatton anncatton mentioned this issue May 10, 2021
Open
@anncatton
Copy link
Contributor Author

Will handle strict mode typing in #173

@anncatton anncatton mentioned this issue May 10, 2021
Merged
@rosibaj
Copy link

rosibaj commented May 14, 2021

Tested May 14, 2021 - absolutely no issues found. Moving to awaiting release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anncatton anncatton

Labels
4.3.0 canarie major High Priority SP:5 Issue is estimated at 5 story points
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anncatton @rosibaj @b-f-chan