Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - AssertJ causing long compile times #376

Closed
andricDu opened this issue Aug 2, 2019 · 1 comment
Closed

BUG - AssertJ causing long compile times #376

andricDu opened this issue Aug 2, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@andricDu
Copy link
Contributor

andricDu commented Aug 2, 2019

AssertJ was identified as causing long test compile times.

Description

Currently AssertJ has been the cause of long compile times for the tests. I removed a lot of it from our existing code and it alleviated the issue a lot. We should make the effort to remove it from the rest of the tests.

Expected Behaviour

mvn test-compile should not take a long time

Actual Behaviour

mvn test-compile takes longer than it should

Possible Fix

replace AssertJ.assertThat calls with just the basic Junit.assertEquals and the like.

Steps to Reproduce

Run mvn test-compile

Your Environment

JDK11 Mac and Linux

@andricDu andricDu added the bug Something isn't working label Aug 2, 2019
@jaserud
Copy link
Contributor

jaserud commented Aug 9, 2019

This has been resolved in #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants