Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Client connection timeout stops indexing #250

Open
justincorrigible opened this issue Jul 11, 2022 · 0 comments
Open

BUG - Client connection timeout stops indexing #250

justincorrigible opened this issue Jul 11, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@justincorrigible
Copy link
Member

Describe the bug

As noticed in VirusSeq, when a request is made for Maestro to index a study (e.g., from its swagger, or using postman), if the connection times out, Maestro stops indexing without notification.
In our case, as a workaround, we modified Nginx's ingress annotation for read timeout; which is not ideal and got the job done, but doesn't solve the underlying issue.

Expected behaviour

If Maestro will stop indexing for whatever reason, a log message should be produced to indicate the process has been stopped on purpose. Alternatively, rather than stopping the process when the connection drops (which could happen for a myriad of unexpected reasons), Maestro could immediately respond with a "201. Starting indexing study XYZ", and it should then continue indexing in the background, at least until a command to stop or cancel is sent.

Furthermore, If it doesn't already exist, another endpoint may be implemented for users to inspect which studies are in progress etc.


Edit: linking icgc-argo/roadmap#874 to distinguish them, for even though is similar enough, they're not quite the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants