Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbrowse feedback: Selection logic & errors #171

Closed
samrichca opened this issue Jul 24, 2023 · 1 comment
Closed

Jbrowse feedback: Selection logic & errors #171

samrichca opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels

Comments

@samrichca
Copy link
Member

samrichca commented Jul 24, 2023

  • Make errors more explicit. (See number 7 & 8) QA Feedback Mega Ticket dms-jbrowse-components#18 (comment)
  • Improve selection logic. If the user selects more than X files, regardless of compatibility, block Jbrowse. Update tooltip wording to reflect this.
  • Make sure Jbrowse compatibility state is accurate (see Patrick's bug about selecting/unselecting controlled/open access files).

  • Disable Jbrowse button & show tooltip (& error message in the Jbrowse tab, if it was previously opened):
    • If user selects >5 files: "Too many files have been selected. A maximum of 5 files may be selected at once."
    • If user selects 0 files: "0 files have been selected. Please select 1-5 files to launch JBrowse."
    • If the user selects 1-5 files and none are compatible: use current wording.
  • If the user selects 1-5 files and some aren't compatible, on the Jbrowse tab, show the visualization & selected files table, and show the yellow warning message with a list of incompatible filenames.
@b-f-chan
Copy link

All errors tested successfully on QA, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants