feat: Allow setting the user-agent in WASM binary + add a setter for the endpoint

Signed-off-by: Arthur Amstutz <[email protected]>

Author: amstuta

.github/workflows/golang-build.yaml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go-version: ["1.20", "1.21", "1.22"]
+        go-version: ["1.20", "1.21", "1.22", "1.23", "1.24"]
 
     steps:
       - uses: actions/checkout@v3

ovh/configuration.go

@@ -97,7 +97,7 @@ func loadINI() (*ini.File, error) {
 // - /etc/ovh.conf
 func (c *Client) loadConfig(endpointName string) error {
 	if strings.HasSuffix(endpointName, "/") {
-		return fmt.Errorf("endpoint name cannot have a tailing slash")
+		return fmt.Errorf("endpoint name cannot have a trailing slash")
 	}
 
 	// Load configuration files by order of increasing priority. All configuration

ovh/configuration_test.go

@@ -30,7 +30,7 @@ func setConfigPaths(t testing.TB, paths ...string) {
 func TestConfigForbidsTrailingSlash(t *testing.T) {
 	client := Client{}
 	err := client.loadConfig("https://example.org/")
-	td.Require(t).String(err, "endpoint name cannot have a tailing slash")
+	td.Require(t).String(err, "endpoint name cannot have a trailing slash")
 }
 
 func TestConfigFromFiles(t *testing.T) {

ovh/ovh.go

@@ -10,6 +10,7 @@ import (
 	"fmt"
 	"io/ioutil"
 	"net/http"
+	"runtime"
 	"strconv"
 	"strings"
 	"sync/atomic"
@@ -162,6 +163,16 @@ func (c *Client) Endpoint() string {
 	return c.endpoint
 }
 
+func (c *Client) SetEndpoint(endpoint string) error {
+	if strings.HasSuffix(endpoint, "/") {
+		return errors.New("endpoint name cannot have a trailing slash")
+	}
+
+	c.endpoint = endpoint
+
+	return nil
+}
+
 //
 // High level helpers
 //
@@ -377,7 +388,13 @@ func (c *Client) NewRequest(method, path string, reqBody interface{}, needAuth b
 	c.Client.Timeout = c.Timeout
 
 	if c.UserAgent != "" {
-		req.Header.Set("User-Agent", "github.com/ovh/go-ovh ("+c.UserAgent+")")
+		// When running in a WebAssembly binary, let the caller set
+		// the user-agent freely to be able to use the browser's one.
+		if runtime.GOARCH == "wasm" && runtime.GOOS == "js" {
+			req.Header.Set("User-Agent", c.UserAgent)
+		} else {
+			req.Header.Set("User-Agent", "github.com/ovh/go-ovh ("+c.UserAgent+")")
+		}
 	} else {
 		req.Header.Set("User-Agent", "github.com/ovh/go-ovh")
 	}

ovh/ovh_test.go

@@ -685,3 +685,18 @@ func TestOAuth2_ForReal(t *testing.T) {
 	assert.Contains(out.Identities[0], "/oauth2-")
 	assert.Contains(out.Identities[0], ":identity:credential:")
 }
+
+func TestSetManualEndpointValid(t *testing.T) {
+	client := &Client{}
+	err := client.SetEndpoint("/fake-endpoint")
+
+	td.CmpNoError(t, err)
+	td.CmpString(t, client.Endpoint(), "/fake-endpoint")
+}
+
+func TestSetManualEndpointInvalid(t *testing.T) {
+	client := &Client{}
+	err := client.SetEndpoint("/invalid-endpoint/")
+
+	td.CmpString(t, err, "endpoint name cannot have a trailing slash")
+}