Remove getDirectoryAsZip() - uses non-public API

Author: DeepDiver1975

owncloud/fileManagement.js

@@ -204,33 +204,6 @@ files.prototype.getFile = function(path, localPath) {
     });
 };
 
-/**
- * Downloads a remote directory as zip
- * @param   {string} remotePath path of the folder at OC instance
- * @param   {string} localPath  path where to download
- * @returns {Promise.<status>}  boolean: whether the operation was successful
- * @returns {Promise.<error>}   string: error message, if any.
- */
-files.prototype.getDirectoryAsZip = function(path, localPath) {
-    path = helpers._normalizePath(path);
-    localPath = localPath || __dirname + path;
-    localPath = helpers._checkExtensionZip(localPath);
-    path = helpers._encodeString(path);
-    path = encodeURIComponent(path);
-    path = path.split('%2F').join('/');
-
-    var url = helpers.instance + 'index.php/apps/files/ajax/download.php?dir=' + (path);
-
-    return new Promise((resolve, reject) => {
-        helpers._writeData(url, localPath)
-            .then(status => {
-                resolve(status);
-            }).catch(error => {
-                reject(error);
-            });
-    });
-};
-
 /**
  * Upload a file
  * @param   {string}  remotePath path of the file to be created at OC instance
@@ -252,7 +225,7 @@ files.prototype.putFile = function(path, localPath, keepMTime) {
     }
 
     headers['Content-Length'] = helpers._getFileSize(localPath);
-    headers.authorization = "Basic " + new Buffer(helpers._username + ":" + helpers._password).toString('base64');
+    headers.authorization = helpers._authHeader;
 
     return new Promise((resolve, reject) => {
         helpers._readFile(path, localPath, headers).then(status => {

owncloud/test/test.js

@@ -1828,33 +1828,6 @@ describe("Currently testing files management,", function () {
 		});
 	});
 
-	it('checking method : getDirectoryAsZip for an existent folder', function (done) {
-		oc.files.getDirectoryAsZip(testFolder, downloadBasePath + timeRightNow +'.zip').then(status => {
-			expect(status).toBe(true);
-
-			fs.readFile(downloadBasePath + timeRightNow +'.zip', function(err, data) {
-			    JSZip.loadAsync(data).then(function (zip) {
-			        var count = Object.keys(zip.files).length;
-			        expect(count).toEqual(7);
-			        done();
-			    });
-			});
-		}).catch(error => {
-			expect(error).toBe(null);
-			done();
-		});
-	});
-
-	it('checking method : getDirectoryAsZip for a non existent folder', function (done) {
-		oc.files.getDirectoryAsZip(testFolder + timeRightNow, downloadBasePath + timeRightNow +'.zip').then(status => {
-			expect(status).toBe(null);
-			done();
-		}).catch(error => {
-			expect(error).toBe('specified file/folder could not be located');
-			done();
-		});
-	});
-
 	it('checking method : putFile for an existent file', function (done) {
 		oc.files.putFile('/', localFile).then(status => {
 			expect(status).toBe(true);
@@ -1897,7 +1870,7 @@ describe("Currently testing files management,", function () {
 			expect(status).toBe(true);
 			return oc.files.list(testFolder + '/testDownloadDir', 'infinity');
 		}).then(files => {
-			expect(files.length).toEqual(5);
+			expect(files.length).toEqual(3);
 			done();
 		}).catch(error => {
 			expect(error).toBe(null);

owncloud/test/testUnauthenticated.js

@@ -587,16 +587,6 @@ describe("Currently testing files management,", function() {
         });
     });
 
-    it('checking method : getDirectoryAsZip', function(done) {
-        oc.files.getDirectoryAsZip(testFolder, downloadBasePath + timeRightNow + '.zip').then(status => {
-            expect(status).toBe(null);
-            done();
-        }).catch(error => {
-            expect(errors.indexOf(error)).toBeGreaterThan(-1);
-            done();
-        });
-    });
-
     it('checking method : putFile', function(done) {
         try {
             oc.files.putFile('/', localFile).then(status => {

owncloud/test/testUnauthorized.js

@@ -602,16 +602,6 @@ describe("Currently testing files management,", function() {
         });
     });
 
-    it('checking method : getDirectoryAsZip', function(done) {
-        oc.files.getDirectoryAsZip(testFolder, downloadBasePath + timeRightNow + '.zip').then(status => {
-            expect(status).toBe(null);
-            done();
-        }).catch(error => {
-            expect(errors.indexOf(error)).toBeGreaterThan(-1);
-            done();
-        });
-    });
-
     it('checking method : putFile', function(done) {
         try {
             oc.files.putFile('/', localFile).then(status => {