Skip to content

Commit be26861

Browse files
committed
Switch from hardcoding gnome-terminal to using xdg-terminal-exec
This is packaged in various Linux distros already: https://repology.org/project/xdg-terminal-exec/versions and we can't assume that gnome-terminal is preinstalled anymore (CentOS Stream 10, RHEL 10 and derivatives, Fedora 47+ and Ubuntu have switched to ptyxis by default) (not sure why the openSUSE version number is weird) Signed-off-by: Michel Lind <[email protected]>
1 parent 1326404 commit be26861

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ More precisely, Argos is a GNOME Shell extension that turns executables' standar
2222

2323
## Installation
2424

25+
### Dependencies
26+
27+
For GNOME 45 and newer, you need `xdg-terminal-exec` since on newer GNOME
28+
releases we cannot assume `gnome-terminal` is preinstalled.
29+
2530
### Manually using git (all recent GNOME shell versions)
2631

2732
Clone the repository:

[email protected]/menuitem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const cArgosMenuItem = GObject.registerClass(
6464
} else {
6565
// Run shell immediately after executing the command to keep the terminal window open
6666
// (see http://stackoverflow.com/q/3512055)
67-
argv = ["gnome-terminal", "--", "bash", "-c", activeLine.bash + "; exec ${SHELL:=bash}"];
67+
argv = ["xdg-terminal-exec", "--", "bash", "-c", activeLine.bash + "; exec ${SHELL:=bash}"];
6868
}
6969

7070
let [success, pid] = GLib.spawn_async(

0 commit comments

Comments
 (0)