Skip to content

Switch from hardcoding gnome-terminal to using xdg-terminal-exec #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch from hardcoding gnome-terminal to using xdg-terminal-exec #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ More precisely, Argos is a GNOME Shell extension that turns executables' standar

## Installation

### Dependencies

For GNOME 45 and newer, you need `xdg-terminal-exec` since on newer GNOME
releases we cannot assume `gnome-terminal` is preinstalled.

Copy link
Collaborator

@mwilck mwilck Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS the xdg-terminal-exec is still a proposal, and not an accepted standard.

This may work on new installations, but has high potential of breaking existing ones. I, for one, use a openSUSE Tumbleweed, and while my distro is fully up to date, I don't have xdg-terminal-exec on my system.

Side note: There is no Fedora 47, and the openSUSE "version number" (I suppose you're referring to Tumbleweed, which is a rolling distro) is just date expression.

### Manually using git (all recent GNOME shell versions)

Clone the repository:
Expand Down
2 changes: 1 addition & 1 deletion [email protected]/menuitem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const cArgosMenuItem = GObject.registerClass(
} else {
// Run shell immediately after executing the command to keep the terminal window open
// (see http://stackoverflow.com/q/3512055)
argv = ["gnome-terminal", "--", "bash", "-c", activeLine.bash + "; exec ${SHELL:=bash}"];
argv = ["xdg-terminal-exec", "--", "bash", "-c", activeLine.bash + "; exec ${SHELL:=bash}"];
Copy link
Collaborator

@mwilck mwilck Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I'd only accept a commit that would test if xdg-terminal-exec was available and fall back to gnome-terminal otherwise.

}

let [success, pid] = GLib.spawn_async(
Expand Down