Fix duplicated base64 encoding of secrets

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>

Author: J12934

auto-discovery/kubernetes/pull-secret-extractor/internal/secret_extraction/secret_extraction.go

@@ -161,8 +161,8 @@ func extractCredentials(auth *AuthEntry) (*Credentials, error) {
 		}
 
 		return &Credentials{
-			Username: base64.StdEncoding.EncodeToString([]byte(parts[0])),
-			Password: base64.StdEncoding.EncodeToString([]byte(parts[1])),
+			Username: parts[0],
+			Password: parts[1],
 		}, nil
 	}
 
@@ -190,9 +190,9 @@ func buildSecret(ctx context.Context, k8sClient client.Client, secretName, names
 				},
 			},
 		},
-		Data: map[string][]byte{
-			"username": []byte(creds.Username),
-			"password": []byte(creds.Password),
+		StringData: map[string]string{
+			"username": creds.Username,
+			"password": creds.Password,
 		},
 		Type: v1.SecretTypeOpaque,
 	}, nil

auto-discovery/kubernetes/pull-secret-extractor/internal/secret_extraction/secret_extraction_test.go

@@ -64,15 +64,15 @@ func TestCreateTemporarySecret(t *testing.T) {
 		t.Fatalf("Secret was not created: %v", err)
 	}
 
-	expectedUsername := base64.StdEncoding.EncodeToString([]byte("testuser"))
-	expectedPassword := base64.StdEncoding.EncodeToString([]byte("testpass"))
+	expectedUsername := "testuser"
+	expectedPassword := "testpass"
 
-	if string(secret.Data["username"]) != expectedUsername {
-		t.Errorf("Expected username %s, got %s", expectedUsername, string(secret.Data["username"]))
+	if secret.StringData["username"] != expectedUsername {
+		t.Errorf("Expected username %s, got %s", expectedUsername, string(secret.StringData["username"]))
 	}
 
-	if string(secret.Data["password"]) != expectedPassword {
-		t.Errorf("Expected password %s, got %s", expectedPassword, string(secret.Data["password"]))
+	if secret.StringData["password"] != expectedPassword {
+		t.Errorf("Expected password %s, got %s", expectedPassword, string(secret.StringData["password"]))
 	}
 
 	if len(secret.OwnerReferences) != 1 {