You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: [IOPLT-997] Fix visual issue on dark mode version of TabItem (#420)
## Short description
This PR fixes a visual issue that was present in the dark mode version
of the `TabItem` component.
## List of changes proposed in this pull request
- Remove the `useAnimatedStyle` dependency in the `TabItem` component,
which was probably causing the buggy behavior
- Remove the `fullWidth` prop because it was never referenced or
officially supported
- Slightly refactor `TabNavigation` to replace old logic with the new
`gap` property
### Preview
> [!note]
> Please note the border of the selected state, before and after
| Before | After |
|--------|--------|
| <video
src="https://github.com/user-attachments/assets/b80b0bbd-2c6f-4d90-9119-6f80faea814f"
/> | <video
src="https://github.com/user-attachments/assets/ed061deb-7b13-4ed5-ac44-0bdfbac87585"
/> |
## How to test
There's no easy way to replicate the buggy behavior in the example app
included in this repo. But you can test the behavior in the `io-app`
repo by updating the `"@pagopa/io-app-design-system"` field in the
`package.json` with the PR `https` url of this PR:
```json
"@pagopa/io-app-design-system": "https://github.com/pagopa/io-app-design-system#IOPLT-997-fix-visual-issue-tabitem-darkmode"
```
Co-authored-by: Emanuele Dall'Ara <[email protected]>
0 commit comments