perf: avoid O(n²) array copies when merging worker TestResults#1106
Closed
jorgsowa wants to merge 1 commit into
Closed
perf: avoid O(n²) array copies when merging worker TestResults#1106jorgsowa wants to merge 1 commit into
jorgsowa wants to merge 1 commit into
Conversation
Replace 21 array_merge_recursive calls per result file with mutable accumulators and array_push, then construct TestResult once after the loop. Reduces complexity from O(N²×M) to O(N×M).
jorgsowa
force-pushed
the
perf/reduce-array-merge-in-complete
branch
from
66a5a5c to
48fd7ba
Compare
Member
|
Please ensure the build pass on your local machine using |
Author
|
Yes, sorry. That's why I marked PR as a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 21 array_merge_recursive calls per result file with mutable accumulators and array_push, then construct TestResult once after the loop. Reduces complexity from O(N²×M) to O(N×M).
Doesn't look pretty, though. Maybe a later helper can be created to improve readability.