Skip to content

Commit 179f63a

Browse files
authored
Add logging for failed dev dep requests (#9638)
1 parent 2df56ed commit 179f63a

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

packages/core/core/src/RequestTracker.js

+14-1
Original file line numberDiff line numberDiff line change
@@ -1166,7 +1166,8 @@ export default class RequestTracker {
11661166
request: Request<TInput, TResult>,
11671167
opts?: ?RunRequestOpts,
11681168
): Promise<TResult> {
1169-
let requestId = this.graph.hasContentKey(request.id)
1169+
let hasKey = this.graph.hasContentKey(request.id);
1170+
let requestId = hasKey
11701171
? this.graph.getNodeIdByContentKey(request.id)
11711172
: undefined;
11721173
let hasValidResult = requestId != null && this.hasValidResult(requestId);
@@ -1224,6 +1225,18 @@ export default class RequestTracker {
12241225
deferred.resolve(true);
12251226
return result;
12261227
} catch (err) {
1228+
if (request.type === requestTypes.dev_dep_request) {
1229+
logger.verbose({
1230+
origin: '@parcel/core',
1231+
message: `Failed DevDepRequest`,
1232+
meta: {
1233+
trackableEvent: 'failed_dev_dep_request',
1234+
hasKey,
1235+
hasValidResult,
1236+
},
1237+
});
1238+
}
1239+
12271240
this.rejectRequest(requestNodeId);
12281241
deferred.resolve(false);
12291242
throw err;

packages/core/core/src/requests/DevDepRequest.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,17 @@ export async function runDevDepRequest<TResult>(
191191
id: 'dev_dep_request:' + devDepRequest.specifier + ':' + devDepRequest.hash,
192192
type: requestTypes.dev_dep_request,
193193
run: ({api}) => {
194-
for (let filePath of nullthrows(devDepRequest.invalidateOnFileChange)) {
194+
for (let filePath of nullthrows(
195+
devDepRequest.invalidateOnFileChange,
196+
'DevDepRequest missing invalidateOnFileChange',
197+
)) {
195198
api.invalidateOnFileUpdate(filePath);
196199
api.invalidateOnFileDelete(filePath);
197200
}
198201

199202
for (let invalidation of nullthrows(
200203
devDepRequest.invalidateOnFileCreate,
204+
'DevDepRequest missing invalidateOnFileCreate',
201205
)) {
202206
api.invalidateOnFileCreate(invalidation);
203207
}

0 commit comments

Comments
 (0)