Skip to content

Commit 4cd9467

Browse files
Collect request stats (#9633)
Co-authored-by: mattcompiles <[email protected]>
1 parent 7734c0e commit 4cd9467

File tree

5 files changed

+45
-1
lines changed

5 files changed

+45
-1
lines changed

packages/core/core/src/Parcel.js

+3
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ export default class Parcel {
360360
bundleGraph: event.bundleGraph,
361361
buildTime: 0,
362362
requestBundle: event.requestBundle,
363+
unstable_requestStats: {},
363364
};
364365
}
365366

@@ -383,6 +384,7 @@ export default class Parcel {
383384

384385
return result;
385386
},
387+
unstable_requestStats: this.#requestTracker.flushStats(),
386388
};
387389

388390
await this.#reporterRunner.report(event);
@@ -400,6 +402,7 @@ export default class Parcel {
400402
let event = {
401403
type: 'buildFailure',
402404
diagnostics: Array.isArray(diagnostic) ? diagnostic : [diagnostic],
405+
unstable_requestStats: this.#requestTracker.flushStats(),
403406
};
404407

405408
await this.#reporterRunner.report(event);

packages/core/core/src/RequestTracker.js

+24
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ export const requestTypes = {
164164
};
165165

166166
type RequestType = $Values<typeof requestTypes>;
167+
type RequestTypeName = $Keys<typeof requestTypes>;
167168

168169
type RequestGraphNode =
169170
| RequestNode
@@ -1027,6 +1028,7 @@ export default class RequestTracker {
10271028
farm: WorkerFarm;
10281029
options: ParcelOptions;
10291030
signal: ?AbortSignal;
1031+
stats: Map<RequestType, number> = new Map();
10301032

10311033
constructor({
10321034
graph,
@@ -1205,6 +1207,9 @@ export default class RequestTracker {
12051207

12061208
try {
12071209
let node = this.graph.getRequestNode(requestNodeId);
1210+
1211+
this.stats.set(request.type, (this.stats.get(request.type) ?? 0) + 1);
1212+
12081213
let result = await request.run({
12091214
input: request.input,
12101215
api,
@@ -1227,6 +1232,25 @@ export default class RequestTracker {
12271232
}
12281233
}
12291234

1235+
flushStats(): {[requestType: string]: number} {
1236+
let requestTypeEntries = {};
1237+
1238+
for (let key of (Object.keys(requestTypes): RequestTypeName[])) {
1239+
requestTypeEntries[requestTypes[key]] = key;
1240+
}
1241+
1242+
let formattedStats = {};
1243+
1244+
for (let [requestType, count] of this.stats.entries()) {
1245+
let requestTypeName = requestTypeEntries[requestType];
1246+
formattedStats[requestTypeName] = count;
1247+
}
1248+
1249+
this.stats = new Map();
1250+
1251+
return formattedStats;
1252+
}
1253+
12301254
createAPI<TResult>(
12311255
requestId: NodeId,
12321256
previousInvalidations: Array<RequestInvalidation>,

packages/core/core/src/requests/AssetGraphRequest.js

+15
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import type {StaticRunOpts, RunAPI} from '../RequestTracker';
1616
import type {EntryResult} from './EntryRequest';
1717
import type {PathRequestInput} from './PathRequest';
1818
import type {Diagnostic} from '@parcel/diagnostic';
19+
import logger from '@parcel/logger';
1920

2021
import invariant from 'assert';
2122
import nullthrows from 'nullthrows';
@@ -200,7 +201,9 @@ export class AssetGraphBuilder {
200201
'A root node is required to traverse',
201202
);
202203

204+
let visitedAssetGroups = new Set();
203205
let visited = new Set([rootNodeId]);
206+
204207
const visit = (nodeId: NodeId) => {
205208
if (errors.length > 0) {
206209
return;
@@ -223,6 +226,10 @@ export class AssetGraphBuilder {
223226
(!visited.has(childNodeId) || child.hasDeferred) &&
224227
this.shouldVisitChild(nodeId, childNodeId)
225228
) {
229+
if (child.type === 'asset_group') {
230+
visitedAssetGroups.add(childNodeId);
231+
}
232+
226233
visited.add(childNodeId);
227234
visit(childNodeId);
228235
}
@@ -232,6 +239,14 @@ export class AssetGraphBuilder {
232239
visit(rootNodeId);
233240
await this.queue.run();
234241

242+
logger.verbose({
243+
origin: '@parcel/core',
244+
message: 'Asset graph walked',
245+
meta: {
246+
visitedAssetGroupsCount: visitedAssetGroups.size,
247+
},
248+
});
249+
235250
if (this.prevChangedAssetsPropagation) {
236251
// Add any previously seen Assets that have not been propagated yet to
237252
// 'this.changedAssetsPropagation', but only if they still remain in the graph

packages/core/types-internal/src/index.js

+2
Original file line numberDiff line numberDiff line change
@@ -1976,6 +1976,7 @@ export type BuildSuccessEvent = {|
19761976
+buildTime: number,
19771977
+changedAssets: Map<string, Asset>,
19781978
+requestBundle: (bundle: NamedBundle) => Promise<BuildSuccessEvent>,
1979+
+unstable_requestStats: {[requestType: string]: number},
19791980
|};
19801981

19811982
/**
@@ -1985,6 +1986,7 @@ export type BuildSuccessEvent = {|
19851986
export type BuildFailureEvent = {|
19861987
+type: 'buildFailure',
19871988
+diagnostics: Array<Diagnostic>,
1989+
+unstable_requestStats: {[requestType: string]: number},
19881990
|};
19891991

19901992
/**

packages/reporters/tracer/src/TracerReporter.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ export default (new Reporter({
6666
case 'buildSuccess':
6767
case 'buildFailure':
6868
nullthrows(tracer).flush();
69+
tracer = null;
6970
// We explicitly trigger `end` on the writeStream for the trace, then we need to wait for
7071
// the `close` event before resolving the promise this report function returns to ensure
7172
// that the file has been properly closed and moved from it's temp location before Parcel
7273
// shuts down.
7374
return new Promise((resolve, reject) => {
7475
nullthrows(writeStream).once('close', err => {
7576
writeStream = null;
76-
tracer = null;
7777
if (err) {
7878
reject(err);
7979
} else {

0 commit comments

Comments
 (0)