Skip to content

Commit f0ff4ed

Browse files
authored
Log project root create, init reporters before the request tracker (#9562)
* Log project root create, init reporters before request tracker * Fix tests
1 parent 40c370f commit f0ff4ed

File tree

5 files changed

+49
-18
lines changed

5 files changed

+49
-18
lines changed

packages/core/core/src/Parcel.js

+9-5
Original file line numberDiff line numberDiff line change
@@ -141,18 +141,22 @@ export default class Parcel {
141141
this.#watchEvents = new ValueEmitter();
142142
this.#disposable.add(() => this.#watchEvents.dispose());
143143

144-
this.#requestTracker = await RequestTracker.init({
145-
farm: this.#farm,
146-
options: resolvedOptions,
147-
});
148-
149144
this.#reporterRunner = new ReporterRunner({
150145
config: this.#config,
151146
options: resolvedOptions,
152147
workerFarm: this.#farm,
153148
});
154149
this.#disposable.add(this.#reporterRunner);
155150

151+
logger.verbose({
152+
origin: '@parcel/core',
153+
message: 'Intializing request tracker...',
154+
});
155+
this.#requestTracker = await RequestTracker.init({
156+
farm: this.#farm,
157+
options: resolvedOptions,
158+
});
159+
156160
this.#initialized = true;
157161
}
158162

packages/core/core/src/RequestTracker.js

+8
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import type {
1616
InternalFileCreateInvalidation,
1717
InternalGlob,
1818
} from './types';
19+
import logger from '@parcel/logger';
1920
import type {Deferred} from '@parcel/utils';
2021

2122
import invariant from 'assert';
@@ -759,6 +760,13 @@ export class RequestGraph extends ContentGraph<
759760
// this means the project root was moved and we need to
760761
// re-run all requests.
761762
if (type === 'create' && filePath === '') {
763+
// $FlowFixMe(incompatible-call) `trackableEvent` isn't part of the Diagnostic interface
764+
logger.verbose({
765+
origin: '@parcel/core',
766+
message:
767+
'Watcher reported project root create event. Invalidate all nodes.',
768+
trackableEvent: 'project_root_create',
769+
});
762770
for (let [id, node] of this.nodes.entries()) {
763771
if (node?.type === REQUEST) {
764772
this.invalidNodeIds.add(id);

packages/core/integration-tests/test/babel.js

+12-7
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,12 @@ describe('babel', function () {
101101
it('should support compiling with babel using babel.config.json config without warnings', async function () {
102102
let messages = [];
103103
let loggerDisposable = Logger.onLog(message => {
104-
messages.push(message);
104+
if (message.level !== 'verbose') {
105+
messages.push(message);
106+
}
105107
});
106108
await bundle(
107109
path.join(__dirname, '/integration/babel-config-json-custom/index.js'),
108-
{
109-
logLevel: 'verbose',
110-
},
111110
);
112111
loggerDisposable.dispose();
113112

@@ -621,7 +620,9 @@ describe('babel', function () {
621620
it('should warn when a babel config contains only redundant plugins', async function () {
622621
let messages = [];
623622
let loggerDisposable = Logger.onLog(message => {
624-
messages.push(message);
623+
if (message.level !== 'verbose') {
624+
messages.push(message);
625+
}
625626
});
626627
let filePath = path.join(__dirname, '/integration/babel-warn-all/index.js');
627628
await bundle(filePath);
@@ -699,7 +700,9 @@ describe('babel', function () {
699700
it('should warn when a babel config contains redundant plugins', async function () {
700701
let messages = [];
701702
let loggerDisposable = Logger.onLog(message => {
702-
messages.push(message);
703+
if (message.level !== 'verbose') {
704+
messages.push(message);
705+
}
703706
});
704707
let filePath = path.join(
705708
__dirname,
@@ -755,7 +758,9 @@ describe('babel', function () {
755758
it('should warn when a JSON5 babel config contains redundant plugins', async function () {
756759
let messages = [];
757760
let loggerDisposable = Logger.onLog(message => {
758-
messages.push(message);
761+
if (message.level !== 'verbose') {
762+
messages.push(message);
763+
}
759764
});
760765
let filePath = path.join(
761766
__dirname,

packages/core/integration-tests/test/bundler.js

+15-5
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,9 @@ describe('bundler', function () {
117117

118118
let messages = [];
119119
let loggerDisposable = Logger.onLog(message => {
120-
messages.push(message);
120+
if (message.level !== 'verbose') {
121+
messages.push(message);
122+
}
121123
});
122124
let b = await bundle(
123125
path.join(__dirname, 'disable-shared-bundles-true-parallel/index.js'),
@@ -200,7 +202,9 @@ describe('bundler', function () {
200202

201203
let messages = [];
202204
let loggerDisposable = Logger.onLog(message => {
203-
messages.push(message);
205+
if (message.level !== 'verbose') {
206+
messages.push(message);
207+
}
204208
});
205209
let b = await bundle(
206210
path.join(
@@ -286,7 +290,9 @@ describe('bundler', function () {
286290

287291
let messages = [];
288292
let loggerDisposable = Logger.onLog(message => {
289-
messages.push(message);
293+
if (message.level !== 'verbose') {
294+
messages.push(message);
295+
}
290296
});
291297
let b = await bundle(
292298
path.join(__dirname, 'disable-shared-bundles-true-min-bundles/index.js'),
@@ -371,7 +377,9 @@ describe('bundler', function () {
371377

372378
let messages = [];
373379
let loggerDisposable = Logger.onLog(message => {
374-
messages.push(message);
380+
if (message.level !== 'verbose') {
381+
messages.push(message);
382+
}
375383
});
376384
let b = await bundle(
377385
path.join(
@@ -481,7 +489,9 @@ describe('bundler', function () {
481489

482490
let messages = [];
483491
let loggerDisposable = Logger.onLog(message => {
484-
messages.push(message);
492+
if (message.level !== 'verbose') {
493+
messages.push(message);
494+
}
485495
});
486496
let b = await bundle(
487497
path.join(__dirname, 'disable-shared-bundles-false/index.js'),

packages/core/integration-tests/test/javascript.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -3264,7 +3264,11 @@ describe('javascript', function () {
32643264

32653265
it('should warn on process.env mutations in node_modules', async function () {
32663266
let logs = [];
3267-
let disposable = Logger.onLog(d => logs.push(d));
3267+
let disposable = Logger.onLog(d => {
3268+
if (d.level !== 'verbose') {
3269+
logs.push(d);
3270+
}
3271+
});
32683272
let b = await bundle(
32693273
path.join(__dirname, '/integration/env-mutate/warn.js'),
32703274
);

0 commit comments

Comments
 (0)