Add cli handling

Author: MonicaOlejniczak

packages/core/integration-tests/test/integration/reporters-failure/.parcelrc

@@ -0,0 +1,4 @@
+{
+  "extends": "@parcel/config-default",
+  "reporters": ["./test-reporter"]
+}

packages/core/integration-tests/test/integration/reporters-failure/index.js

@@ -0,0 +1 @@
+export function main() {}

packages/core/integration-tests/test/integration/reporters-failure/test-reporter/index.js

@@ -0,0 +1,9 @@
+const { Reporter } = require('@parcel/plugin');
+
+module.exports = new Reporter({
+  async report({ event }) {
+    if (event.type === 'buildSuccess') {
+      throw new Error('Failed to report buildSuccess');
+    }
+  }
+});

packages/core/integration-tests/test/integration/reporters-failure/test-reporter/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "test-reporter",
+  "version": "1.0.0",
+  "main": "index.js"
+}

packages/core/integration-tests/test/integration/reporters-failure/yarn.lock

@@ -0,0 +1,4 @@
+{
+  "extends": "@parcel/config-default",
+  "reporters": ["./test-reporter"]
+}

packages/core/integration-tests/test/integration/reporters-success/.parcelrc

@@ -0,0 +1 @@
+export function main() {}

packages/core/integration-tests/test/integration/reporters-success/index.js

@@ -0,0 +1,5 @@
+const { Reporter } = require('@parcel/plugin');
+
+module.exports = new Reporter({
+  async report({ event }) {}
+});

packages/core/integration-tests/test/integration/reporters-success/test-reporter/index.js

@@ -0,0 +1,5 @@
+{
+  "name": "test-reporter",
+  "version": "1.0.0",
+  "main": "index.js"
+}

packages/core/integration-tests/test/integration/reporters-success/test-reporter/package.json

@@ -1,107 +1,73 @@
 // @flow
 
 import assert from 'assert';
+import {execSync} from 'child_process';
 import path from 'path';
 
 import {INTERNAL_ORIGINAL_CONSOLE} from '@parcel/logger';
-import {bundle, fsFixture, overlayFS} from '@parcel/test-utils';
+import {bundle} from '@parcel/test-utils';
 import sinon from 'sinon';
 
-describe.only('reporters', () => {
-  let consoleError;
-  let processExitCode;
-  let dir = path.join(__dirname, 'reporters');
-
-  beforeEach(async () => {
-    processExitCode = process.exitCode;
-    consoleError = sinon.stub(INTERNAL_ORIGINAL_CONSOLE, 'error');
-    await overlayFS.mkdirp(dir);
-  });
-
-  afterEach(async () => {
-    process.exitCode = processExitCode;
-    sinon.restore();
-  });
+describe('reporters', () => {
+  let successfulEntry = path.join(
+    __dirname,
+    'integration',
+    'reporters-success',
+    'index.js',
+  );
+
+  let failingEntry = path.join(
+    __dirname,
+    'integration',
+    'reporters-failure',
+    'index.js',
+  );
+
+  describe('running on the cli', () => {
+    it('exit successfully when no errors are emitted', () => {
+      assert.doesNotThrow(() =>
+        execSync(`parcel build --no-cache ${successfulEntry}`, {
+          stdio: 'ignore',
+        }),
+      );
+    });
 
-  after(async () => {
-    await overlayFS.rimraf(dir);
+    it('exit with an error code when an error is emitted', () => {
+      assert.throws(() =>
+        execSync(`parcel build --no-cache ${failingEntry}`, {stdio: 'ignore'}),
+      );
+    });
   });
 
-  async function createReporterFixture(name: string, reporter: string) {
-    let cwd = path.join(dir, name);
-
-    await overlayFS.mkdirp(cwd);
-
-    await fsFixture(overlayFS, cwd)`
-      index.js:
-        export function main() {}
-
-      test-reporter/index.js:
-        ${reporter}
+  describe('running on the programmatic api', () => {
+    let consoleError;
+    let processExitCode;
 
-      test-reporter/package.json:
-        {
-          "name": "test-reporter",
-          "main": "index.js",
-          "version": "1.0.0"
-        }
-
-      .parcelrc:
-        {
-          "extends": "@parcel/config-default",
-          "reporters": ["./test-reporter"]
-        }
-
-      yarn.lock: {}
-    `;
-
-    return cwd;
-  }
-
-  it('exit successfully when no errors are emitted', async () => {
-    let cwd = await createReporterFixture(
-      'success',
-      `
-      test-reporter/index.js:
-        const { Reporter } = require('@parcel/plugin');
-
-        module.exports = new Reporter({
-          async report({ event }) {}
-        });
-    `,
-    );
+    beforeEach(() => {
+      processExitCode = process.exitCode;
+      consoleError = sinon.stub(INTERNAL_ORIGINAL_CONSOLE, 'error');
+    });
 
-    await bundle(path.join(cwd, 'index.js'), {
-      inputFS: overlayFS,
+    afterEach(() => {
+      process.exitCode = processExitCode;
+      sinon.restore();
     });
 
-    assert(!process.exitCode);
-  });
+    it('exit successfully when no errors are emitted', async () => {
+      await bundle(successfulEntry);
 
-  it('exit with an error code when an error is emitted', async () => {
-    let cwd = await createReporterFixture(
-      'error',
-      `
-      test-reporter/index.js:
-        const { Reporter } = require('@parcel/plugin');
+      assert(!process.exitCode);
+    });
 
-        module.exports = new Reporter({
-          async report({ event }) {
-            if (event.type === 'buildSuccess') {
-              throw new Error('Failed to report buildSuccess');
-            }
-          }
-        });
-    `,
-    );
+    it('exit with an error code when an error is emitted', async () => {
+      await bundle(failingEntry);
 
-    await bundle(path.join(cwd, 'index.js'), {
-      inputFS: overlayFS,
+      assert.equal(process.exitCode, 1);
+      assert(
+        consoleError.calledWithMatch({
+          message: 'Failed to report buildSuccess',
+        }),
+      );
     });
-
-    assert.equal(process.exitCode, 1);
-    assert(
-      consoleError.calledWithMatch({message: 'Failed to report buildSuccess'}),
-    );
   });
 });

packages/core/integration-tests/test/integration/reporters-success/yarn.lock

@@ -404,7 +404,7 @@ async function run(
       await exit(1);
     }
 
-    await exit();
+    await exit(process.exitCode);
   }
 }