-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node globals are not resolved in the dependencies #8433
Comments
#8387 is going to change this to 1. autoinstall node builtin polyfills into the project root if not already installed and 2. always resolve the polyfills from the project root |
The build still fails with the same error on 2.0.0-nightly.1162 |
remove once parcel-bundler/parcel#8433 is fixed
currently parcel's optimization system removes the `process.env.{REACT_APP_NHOST_SUBDOMAIN, REACT_APP_NHOST_REGION}` call, blocking us from setting nhost to use a different subdomain (related: parcel-bundler/parcel#8433)
@aminya I've managed to fix this by adding the |
It seems that time solves the issues. 😄 |
Is it actually fixed already or are you referring to the stale bot being overzealous? |
Not fixed. I was joking |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. |
I didn't test to see if this is resolved. Github bot being unhelpful like always |
Still happens: https://github.com/aminya/patha/actions/runs/11629307228/job/32386054530 Building...
Bundling...
Packaging & Optimizing...
🚨 Build failed.
@parcel/packager-js: External modules are not supported when building for
browser
/home/runner/work/patha/patha/node_modules/.pnpm/path-browserify@1.0.1/node_modules/path-browserify/index.js:124:17
123 | if (cwd === undefined)
> 124 | cwd = process.cwd();
> | ^^^^^^^
125 | path = cwd;
126 | }
ELIFECYCLE Command failed with exit code |
🐛 bug report
The node globals like
process
are not resolved in the dependencies when targeting the browser.🎛 Configuration (.babelrc, package.json, cli command)
https://github.com/aminya/patha/blob/f110c46226ad8b84bd466735e96afa4dfee44616/package.json#L19-L74
🤔 Expected Behavior
the process should be handled as stated in the docs
https://parceljs.org/features/node-emulation/#shimming-builtin-node-globals
😯 Current Behavior
It errors. It seems the Node emulation has several bugs in Parcel. See #8409 #8049 #5090
💁 Possible Solution
Nothing
🔦 Context
💻 Code Sample
aminya/patha#9
🌍 Your Environment
The text was updated successfully, but these errors were encountered: