Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website icon to repl #9555

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

hai-x
Copy link
Contributor

@hai-x hai-x commented Feb 29, 2024

↪️ Pull Request

Add website icon to repl.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@hai-x
Copy link
Contributor Author

hai-x commented Feb 29, 2024

i wonder how to preview this pr by pr-{{PR_NUMBER}}.repl.parceljs.org ?

@mischnic
Copy link
Member

mischnic commented Mar 1, 2024

That is unfortunately not possible right now. For security reasons, Github Action Secrets are not available to external contributors (because you could theoretically change the GH action to extract our Vercel token used to publish that website)

@hai-x
Copy link
Contributor Author

hai-x commented Mar 1, 2024

That is unfortunately not possible right now. For security reasons, Github Action Secrets are not available to external contributors (because you could theoretically change the GH action to extract our Vercel token used to publish that website)

Thanks for your answer. It's okay.

Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mischnic mischnic merged commit 40c370f into parcel-bundler:v2 Mar 2, 2024
13 of 16 checks passed
@hai-x hai-x deleted the haijie-x/feat-repl-website-icon branch December 30, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants