Replace nightly with canary releases #9559
Conversation
MonicaOlejniczak
requested review from
devongovett,
marcins,
mattcompiles and
alshdavid
There was a problem hiding this comment.
Amazing work 🚀
I'm happy but let's make sure @devongovett is aware before merging. Not sure if he has any external reliance on nightly.
Would it be possible to also tag each canary release as a nightly? So |
|
@marcins I can have a look, is that just to make this less of a breaking change? |
|
so it's essentially the same just more often? I agree about adding a dist-tag for nightly as well for people currently using that. |
Yeah, it's so the .. or I guess another option is to just keep Running another lerna publish to nightly will take a bit longer as you need to run the command again with a different dist-tag - I'm not sure how much of the work Lerna can re-use, but looks like that part currently takes ~4 min - I guess you could always do it in parallel? From the npm point of view, I don't think there's any issues with doing this. |
|
@devongovett Yeah, it's the same but more frequent @marcins It can be aliased, but it's a bit tedious to do. I've written a custom script that does this in the latest commit. |
MonicaOlejniczak
force-pushed
the
molejniczak/canary-releases
branch
from
6d0c1ce to
289dcc7
Compare
| async function main(tag) { | ||
| let publishSummary = JSON.parse( | ||
| await readFile( | ||
| new URL('../lerna-publish-summary.json', import.meta.url).pathname, |
There was a problem hiding this comment.
I haven't seen this kind of pattern of using an URL in a readFile, what does it do over a readFile(path.resolve(__dirname, "../lerna-publish-summary.json"))?
There was a problem hiding this comment.
Neither, only just used it for the first time. It's the equivalent to your example in esm land, and will be an absolute path due to accessing pathname
Example: /parcel/lerna-publish-summary.json
↪️ Pull Request
Replaces the nightly release with a canary release, which will trigger on every push to v2 instead of running every night. Other notable changes include:
^3.22.1to^6.6.2to utilise the--summary-fileoption.Regarding lerna, there are no notable breaking changes between versions:
@npmcli/run-scriptovernpm-lifecycle💻 Examples
This change helps us move to trunk based development with a feature flag system as described in #9539
A working dev release enables installation of
parcel@dev-testwhich points to the latestparcel@devversion🚨 Test instructions
Change the target push branch to the current branch