static_types: have a pass over `hardcoded constants`

[niklasad1]

There are a few of hardcoded constants configurations which could be wrong or become outdated if something gets changed in the runtime.

Most likely submitting a valid solution would not work and we will detect it via the integration tests.

Currently we got the following hardcoded stuff (could be outdated):

• MaxBackersPerWinnerFinal = u32::MAX
• MaxVotesPerVoter: 16 (polkadot, westend) and 24 (kusama)
• MaxVoters: 22500 (polkadot, westend) and 12500

[sigurpol]

very draft notes in form of git diff from a meeting with @kianenigma .
Not top priority but we could potentially get rid of all the hardcoded constants.

diff --git a/src/static_types/multi_block.rs b/src/static_types/multi_block.rs
index aec2a33d..07d83b9c 100644
--- a/src/static_types/multi_block.rs
+++ b/src/static_types/multi_block.rs
@@ -97,7 +97,7 @@ pub mod kusama {
             VoterIndex = u32,
             TargetIndex = u16,
             Accuracy = PerU16,
-            MaxVoters = ConstU32::<12500>
+            MaxVoters = ConstU32::<12500> //  NOTE: look at MaxVoters = VoterSnapshotPerBlock see https://github.com/paritytech/polkadot-sdk/blob/d9d767477dd69f58510c05f74de7aa3891b34386/cumulus/parachains/runtimes/assets/asset-hub-westend/src/staking.rs#L80
         >(24)
     );

@@ -111,9 +111,11 @@ pub mod kusama {
         // TODO: make it configurable via CLI https://github.com/paritytech/polkadot-staking-miner/issues/989
         type Solver = SequentialPhragmen<AccountId, Accuracy>;
         type Pages = Pages;
-        type MaxVotesPerVoter = ConstU32<24>;
+        type MaxVotesPerVoter = ConstU32<24>; // TODO: extend metadata and then update the miner to update it dynamically
         type MaxWinnersPerPage = MaxWinnersPerPage;
         type MaxBackersPerWinner = MaxBackersPerWinner;
+        // TODO: this might actually not be a const anymore, we might be able to get via metadata!
+        // see https://github.com/paritytech/polkadot-sdk/blob/d9d767477dd69f58510c05f74de7aa3891b34386/substrate/frame/election-provider-multi-block/src/verifier/impls.rs#L129
         type MaxBackersPerWinnerFinal = ConstU32<{ u32::MAX }>;
         type VoterSnapshotPerBlock = VoterSnapshotPerBlock;
         type TargetSnapshotPerBlock = TargetSnapshotPerBlock;
@@ -129,6 +131,8 @@ pub mod westend {
     // TODO: validate config https://github.com/paritytech/polkadot-staking-miner/issues/994
     frame_election_provider_support::generate_solution_type!(
         #[compact]
+        // NOTe: NposSolution16 or 24 is hardcoded -> see https://github.com/paritytech/polkadot-sdk/blob/d9d767477dd69f58510c05f74de7aa3891b34386/cumulus/parachains/runtimes/assets/asset-hub-westend/src/staking.rs#L89
+        // But maybe we can try to put the 16/24 in the metadata as well in the NPosSolution in the  verifier pallet if not already there?
         pub struct NposSolution16::<
             VoterIndex = u32,
             TargetIndex = u16,