Fix validate license command tests

Author: witcher112

Assets/Editor/Tests/ValidateLicenseCommandTest.cs

@@ -4,6 +4,7 @@
 using NUnit.Framework;
 using PatchKit.Api;
 using PatchKit.Api.Models.Main;
+using PatchKit.Unity.Patcher.AppData.Local;
 using PatchKit.Unity.Patcher.AppData.Remote;
 using PatchKit.Unity.Patcher.AppUpdater.Commands;
 using PatchKit.Unity.Patcher.Cancellation;
@@ -30,6 +31,15 @@ public void Execute_CachesKeyAndKeySecret()
         const string key = "this-key-should-be-cached";
         const string keySecret = "this-key-secret-should-be-cached";
 
+        var remoteMetaData = Substitute.For<IRemoteMetaData>();
+        remoteMetaData.GetAppInfo().Returns(new App()
+        {
+            UseKeys = true
+        });
+        remoteMetaData.GetKeySecret(key, Arg.Any<string>()).Returns(keySecret);
+
+        var localMetaData = Substitute.For<ILocalMetaData>();
+        
         for (int i = 0; i < 2; i++)
         {
             var licenseDialog = Substitute.For<ILicenseDialog>();
@@ -39,28 +49,22 @@ public void Execute_CachesKeyAndKeySecret()
                 Type = LicenseDialogResultType.Confirmed
             });
 
-            var remoteMetaData = Substitute.For<IRemoteMetaData>();
-            remoteMetaData.GetAppInfo().Returns(new App()
-            {
-                UseKeys = true
-            });
-            remoteMetaData.GetKeySecret(key, Arg.Any<string>()).Returns(keySecret);
-            
-            var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, _cache, _logger);
+            var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, localMetaData, _cache, _logger);
             command.Prepare(_statusMonitor);
             command.Execute(CancellationToken.Empty);
 
             if (i == 0)
             {
                 licenseDialog.Received(1).Display(Arg.Any<LicenseDialogMessageType>());
-                Assert.IsTrue(_cache.Dictionary.ContainsValue(key));
+                localMetaData.Received().SetProductKey(key);
+                localMetaData.GetProductKey().Returns(key);
                 Assert.IsTrue(_cache.Dictionary.ContainsValue(keySecret));
             }
             else
             {
                 licenseDialog.Received(1).SetKey(key);
                 licenseDialog.DidNotReceive().Display(Arg.Any<LicenseDialogMessageType>());
-                Assert.IsTrue(_cache.Dictionary.ContainsValue(key));
+                localMetaData.Received().SetProductKey(key);
                 Assert.IsTrue(_cache.Dictionary.ContainsValue(keySecret));
             }
         }
@@ -77,7 +81,9 @@ public void Execute_ProperlyHandlesSitauationWhenKeysAreNotUsed()
             UseKeys = false
         });
 
-        var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, _cache, _logger);
+        var localMetaData = Substitute.For<ILocalMetaData>();
+        
+        var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, localMetaData, _cache, _logger);
         command.Prepare(_statusMonitor);
         command.Execute(CancellationToken.Empty);
 
@@ -106,6 +112,8 @@ public void Execute_DisplaysDialogMessageForApiError(int statusCode, LicenseDial
         {
             UseKeys = true
         });
+        
+        var localMetaData = Substitute.For<ILocalMetaData>();
 
         bool firstAttempt = true;
 
@@ -120,7 +128,7 @@ public void Execute_DisplaysDialogMessageForApiError(int statusCode, LicenseDial
             throw new ApiResponseException(statusCode);
         });
 
-        var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, _cache, _logger);
+        var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, localMetaData, _cache, _logger);
         command.Prepare(_statusMonitor);
         command.Execute(CancellationToken.Empty);
 
@@ -162,7 +170,9 @@ public void Execute_DisplaysProperDialogMessageForConnectionError()
             throw new ApiConnectionException(new List<Exception>(), new List<Exception>());
         });
 
-        var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, _cache, _logger);
+        var localMetaData = Substitute.For<ILocalMetaData>();
+        
+        var command = new ValidateLicenseCommand(licenseDialog, remoteMetaData, localMetaData, _cache, _logger);
         command.Prepare(_statusMonitor);
         command.Execute(CancellationToken.Empty);
 

Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/AppUpdaterCommandFactory.cs

@@ -94,7 +94,7 @@ public IUninstallCommand CreateUninstallCommand(AppUpdaterContext context)
 
         public IValidateLicenseCommand CreateValidateLicenseCommand(AppUpdaterContext context)
         {
-            return new ValidateLicenseCommand(context.LicenseDialog, context.App.RemoteMetaData, new UnityCache(), PatcherLogManager.DefaultLogger);
+            return new ValidateLicenseCommand(context.LicenseDialog, context.App.RemoteMetaData, context.App.LocalMetaData, new UnityCache(), PatcherLogManager.DefaultLogger);
         }
 
         public ICheckDiskSpace CreateCheckDiskSpaceCommandForDiff(int versionId, AppUpdaterContext context)